Re: master d5f515e4a33 1/2: New image type canvas

Michael Albinus <[email protected]>
Newsgroups gmane.emacs.devel
Message-ID <[email protected]>
Eli Zaretskii <[email protected]> writes:

Hi,

>     New image type canvas

This breaks the tests on emba:

--8<---------------cut here---------------start------------->8---
2026-08-22T02:54:16.567909Z 01O Test mod-test-canvas/file backtrace:
2026-08-22T02:54:16.567912Z 01O   signal(error ("Invalid image type `canvas'"))
2026-08-22T02:54:16.567914Z 01O   error("Invalid image type `%s'" canvas)
2026-08-22T02:54:16.567917Z 01O   image-type("../data/image/canvas-argb" canvas nil)
2026-08-22T02:54:16.567919Z 01O   create-image("../data/image/canvas-argb" canvas nil :data-width 128 
2026-08-22T02:54:16.567922Z 01O   (let* ((width 128) (height 98) (canvas (create-image "../data/image/
2026-08-22T02:54:16.567925Z 01O   #f(lambda () [cl-struct-emacs-module-tests--variable-tags t] (test-c
2026-08-22T02:54:16.567928Z 01O   #f(compiled-function () #<bytecode -0x17044dea0b0714dc>)()
2026-08-22T02:54:16.567930Z 01O   handler-bind-1(#f(compiled-function () #<bytecode -0x17044dea0b0714d
2026-08-22T02:54:16.567933Z 01O   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
2026-08-22T02:54:16.567936Z 01O   ert-run-test(#s(ert-test :name mod-test-canvas/file :documentation n
2026-08-22T02:54:16.567939Z 01O   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
2026-08-22T02:54:16.567942Z 01O   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
2026-08-22T02:54:16.567945Z 01O   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
2026-08-22T02:54:16.567947Z 01O   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
2026-08-22T02:54:16.567950Z 01O   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
2026-08-22T02:54:16.567953Z 01O   command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
2026-08-22T02:54:16.567956Z 01O   command-line()
2026-08-22T02:54:16.567973Z 01O   normal-top-level()
2026-08-22T02:54:16.567975Z 01O Test mod-test-canvas/file condition:
2026-08-22T02:54:16.567978Z 01O     (error "Invalid image type `canvas'")
2026-08-22T02:54:16.567980Z 01O    FAILED   5/42  mod-test-canvas/file (0.050538 sec) at src/emacs-module-tests.el:677
2026-08-22T02:54:16.567983Z 01O Test mod-test-canvas/gc-stress backtrace:
2026-08-22T02:54:16.567986Z 01O   mod-test-canvas-read((image :type canvas :id test-canvas :data-width
2026-08-22T02:54:16.567988Z 01O   (let* ((canvas (list 'image ':type 'canvas ':id 'test-canvas ':data-
2026-08-22T02:54:16.567991Z 01O   (let ((x counter)) (let* ((canvas (list 'image ':type 'canvas ':id '
2026-08-22T02:54:16.567994Z 01O   (while (< counter upper-bound) (let ((x counter)) (let* ((canvas (li
2026-08-22T02:54:16.567997Z 01O   (let ((upper-bound 20) (counter 0)) (while (< counter upper-bound) (
2026-08-22T02:54:16.567999Z 01O   (let ((_ counter)) (let ((upper-bound 20) (counter 0)) (while (< cou
2026-08-22T02:54:16.568002Z 01O   (while (< counter upper-bound) (let ((_ counter)) (let ((upper-bound
2026-08-22T02:54:16.568005Z 01O   (let ((upper-bound 10) (counter 0)) (while (< counter upper-bound) (
2026-08-22T02:54:16.568007Z 01O   #f(lambda () [cl-struct-emacs-module-tests--variable-tags t] (let ((
2026-08-22T02:54:16.568010Z 01O   #f(compiled-function () #<bytecode -0x17044dea0b0714dc>)()
2026-08-22T02:54:16.568013Z 01O   handler-bind-1(#f(compiled-function () #<bytecode -0x17044dea0b0714d
2026-08-22T02:54:16.568015Z 01O   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
2026-08-22T02:54:16.568018Z 01O   ert-run-test(#s(ert-test :name mod-test-canvas/gc-stress :documentat
2026-08-22T02:54:16.568096Z 01O   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
2026-08-22T02:54:16.568099Z 01O   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
2026-08-22T02:54:16.568102Z 01O   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
2026-08-22T02:54:16.568105Z 01O   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
2026-08-22T02:54:16.568107Z 01O   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
2026-08-22T02:54:16.568110Z 01O   command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
2026-08-22T02:54:16.568113Z 01O   command-line()
2026-08-22T02:54:16.568115Z 01O   normal-top-level()
2026-08-22T02:54:16.568117Z 01O Test mod-test-canvas/gc-stress condition:
2026-08-22T02:54:16.568120Z 01O     (error "Canvas: No window system")
2026-08-22T02:54:16.568122Z 01O    FAILED   6/42  mod-test-canvas/gc-stress (0.000272 sec) at src/emacs-module-tests.el:695
2026-08-22T02:54:16.568125Z 01O    passed   7/42  mod-test-canvas/invalid (0.000356 sec)
2026-08-22T02:54:16.568128Z 01O Test mod-test-canvas/unibyte backtrace:
2026-08-22T02:54:16.568130Z 01O   mod-test-canvas-read((image :type canvas :id test-canvas :data-width
2026-08-22T02:54:16.568133Z 01O   (let* ((width 458) (height 278) (pixel (unibyte-string 255 128 64 12
2026-08-22T02:54:16.568135Z 01O   #f(lambda () [cl-struct-emacs-module-tests--variable-tags t] (let* (
2026-08-22T02:54:16.568138Z 01O   #f(compiled-function () #<bytecode -0x17044dea0b0714dc>)()
2026-08-22T02:54:16.568141Z 01O   handler-bind-1(#f(compiled-function () #<bytecode -0x17044dea0b0714d
2026-08-22T02:54:16.568143Z 01O   ert--run-test-internal(#s(ert--test-execution-info :test ... :result
2026-08-22T02:54:16.568146Z 01O   ert-run-test(#s(ert-test :name mod-test-canvas/unibyte :documentatio
2026-08-22T02:54:16.568149Z 01O   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
2026-08-22T02:54:16.568151Z 01O   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
2026-08-22T02:54:16.568154Z 01O   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
2026-08-22T02:54:16.568157Z 01O   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
2026-08-22T02:54:16.568159Z 01O   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
2026-08-22T02:54:16.568162Z 01O   command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
2026-08-22T02:54:16.568165Z 01O   command-line()
2026-08-22T02:54:16.568167Z 01O   normal-top-level()
2026-08-22T02:54:16.568169Z 01O Test mod-test-canvas/unibyte condition:
2026-08-22T02:54:16.568172Z 01O     (error "Canvas: No window system")
2026-08-22T02:54:16.568174Z 01O    FAILED   8/42  mod-test-canvas/unibyte (0.012579 sec) at src/emacs-module-tests.el:656
2026-08-22T02:54:16.568177Z 01O Test mod-test-canvas/valid backtrace:
2026-08-22T02:54:16.568179Z 01O   mod-test-canvas-read((image :type canvas :id test-canvas :data-width
2026-08-22T02:54:16.568182Z 01O   (let* ((width 128) (height 215) (canvas (list 'image ':type 'canvas 
2026-08-22T02:54:16.568185Z 01O   #f(lambda () [cl-struct-emacs-module-tests--variable-tags t] (let* (
2026-08-22T02:54:16.568188Z 01O   #f(compiled-function () #<bytecode -0x17044dea0b0714dc>)()
2026-08-22T02:54:16.568191Z 01O   handler-bind-1(#f(compiled-function () #<bytecode -0x17044dea0b0714d
2026-08-22T02:54:16.568194Z 01O   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
2026-08-22T02:54:16.568196Z 01O   ert-run-test(#s(ert-test :name mod-test-canvas/valid :documentation 
2026-08-22T02:54:16.568199Z 01O   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
2026-08-22T02:54:16.568202Z 01O   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
2026-08-22T02:54:16.568205Z 01O   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
2026-08-22T02:54:16.568208Z 01O   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
2026-08-22T02:54:16.568210Z 01O   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
2026-08-22T02:54:16.568224Z 01O   command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
2026-08-22T02:54:16.568227Z 01O   command-line()
2026-08-22T02:54:16.568230Z 01O   normal-top-level()
2026-08-22T02:54:16.568232Z 01O Test mod-test-canvas/valid condition:
2026-08-22T02:54:16.568234Z 01O     (error "Canvas: No window system")
2026-08-22T02:54:16.568237Z 01O    FAILED   9/42  mod-test-canvas/valid (0.000228 sec) at src/emacs-module-tests.el:605
2026-08-22T02:54:16.568240Z 01O Test mod-test-canvas/vector backtrace:
2026-08-22T02:54:16.568242Z 01O   mod-test-canvas-read((image :type canvas :id test-canvas :data-width
2026-08-22T02:54:16.568245Z 01O   (let* ((width 327) (height 98) (canvas (list 'image ':type 'canvas '
2026-08-22T02:54:16.568248Z 01O   #f(lambda () [cl-struct-emacs-module-tests--variable-tags t] (let* (
2026-08-22T02:54:16.568250Z 01O   #f(compiled-function () #<bytecode -0x17044dea0b0714dc>)()
2026-08-22T02:54:16.568253Z 01O   handler-bind-1(#f(compiled-function () #<bytecode -0x17044dea0b0714d
2026-08-22T02:54:16.568256Z 01O   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
2026-08-22T02:54:16.568258Z 01O   ert-run-test(#s(ert-test :name mod-test-canvas/vector :documentation
2026-08-22T02:54:16.568261Z 01O   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
2026-08-22T02:54:16.568264Z 01O   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
2026-08-22T02:54:16.568266Z 01O   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
2026-08-22T02:54:16.568269Z 01O   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
2026-08-22T02:54:16.568271Z 01O   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
2026-08-22T02:54:16.568274Z 01O   command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
2026-08-22T02:54:16.568277Z 01O   command-line()
2026-08-22T02:54:16.568279Z 01O   normal-top-level()
2026-08-22T02:54:16.568281Z 01O Test mod-test-canvas/vector condition:
2026-08-22T02:54:16.568284Z 01O     (error "Canvas: No window system")
2026-08-22T02:54:16.568286Z 01O    FAILED  10/42  mod-test-canvas/vector (0.000465 sec) at src/emacs-module-tests.el:624
2026-08-22T02:54:16.568289Z 01O Test mod-test-canvas/vector-reload backtrace:
2026-08-22T02:54:16.568292Z 01O   mod-test-canvas-read((image :type canvas :id test-canvas :data-width
2026-08-22T02:54:16.568294Z 01O   (let* ((width 198) (height 720) (test-vector (make-vector (* width h
2026-08-22T02:54:16.568297Z 01O   #f(lambda () [cl-struct-emacs-module-tests--variable-tags t] (let* (
2026-08-22T02:54:16.568300Z 01O   #f(compiled-function () #<bytecode -0x17044dea0b0714dc>)()
2026-08-22T02:54:16.568303Z 01O   handler-bind-1(#f(compiled-function () #<bytecode -0x17044dea0b0714d
2026-08-22T02:54:16.568306Z 01O   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
2026-08-22T02:54:16.568309Z 01O   ert-run-test(#s(ert-test :name mod-test-canvas/vector-reload :docume
2026-08-22T02:54:16.568311Z 01O   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
2026-08-22T02:54:16.568314Z 01O   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
2026-08-22T02:54:16.568317Z 01O   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
2026-08-22T02:54:16.568320Z 01O   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
2026-08-22T02:54:16.568322Z 01O   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
2026-08-22T02:54:16.568325Z 01O   command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
2026-08-22T02:54:16.568328Z 01O   command-line()
2026-08-22T02:54:16.568330Z 01O   normal-top-level()
2026-08-22T02:54:16.568332Z 01O Test mod-test-canvas/vector-reload condition:
2026-08-22T02:54:16.568335Z 01O     (error "Canvas: No window system")
2026-08-22T02:54:16.568337Z 01O    FAILED  11/42  mod-test-canvas/vector-reload (0.001714 sec) at src/emacs-module-tests.el:641
--8<---------------cut here---------------end--------------->8---

Likely, the tests would profit from

(skip-unless (functionp 'canvas-refresh))

Best regards, Michael.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.