Re: master d5f515e4a33 1/2: New image type canvas

Eli Zaretskii <[email protected]>
Newsgroups gmane.emacs.devel
Message-ID <[email protected]>
> From: Divya Ranjan Pattanaik <[email protected]>
> Cc: [email protected]
> Date: Sat, 22 Aug 2026 11:07:08 +0000
> 
> Michael Albinus <[email protected]> writes:
> 
> >
> > Likely, the tests would profit from
> >
> > (skip-unless (functionp 'canvas-refresh))
> >
> > Best regards, Michael.
> >
> 
> Hello Michael, thank you for reporting this. Here's a patch, it uses (display-graphic-p) instead. Do we need to do anything about the canvas module function in emacs-module-resources/mod-test.c? Or, is it okay if those never get called from emacs-module-tests.el?

I'm quite sure there's more here than meets the eye, because all of
these tests pass for me in batch mode, both on GNU/Linux and on
MS-Windows.  So display-graphic-p test is definitely not right here,
and will just skip tests for no good reason.

Please look closer into these failures.  We need to understand how
come they fail on Emba, but not on other systems.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.