Re: master d5f515e4a33 1/2: New image type canvas

> From: Divya Ranjan Pattanaik <[email protected]>
> Cc: [email protected],  [email protected]
> Date: Sat, 22 Aug 2026 12:08:21 +0000
> 
> > I'm quite sure there's more here than meets the eye, because all of
> > these tests pass for me in batch mode, both on GNU/Linux and on
> > MS-Windows.  So display-graphic-p test is definitely not right here,
> > and will just skip tests for no good reason.
> >
> > Please look closer into these failures.  We need to understand how
> > come they fail on Emba, but not on other systems.
> >
> 
> I think it's because in Emba it's compiled without GUI, so none of the image types are available. There's this in emacs.c:
> 
> #ifdef HAVE_WINDOW_SYSTEM
>       syms_of_fringe ();
>       syms_of_image ();
> #endif
> 
> I also checked the errors, and one of them is invalid image type. So clearly Emba's emacs build doesn't have the image type, and because it's compiled without GUI, the error when calling module_canvas_data is also valid.
> 
> So you are right, we shouldn't be using display-graphic-p which is too strong, maybe instead (skip-unless (image-type-available-p 'canvas))?

Yes, that's much more reasonable, thanks.