Re: Slow filenotify-tests

> From: Michael Albinus <[email protected]>
> Cc: [email protected]
> Date: Sat, 22 Aug 2026 15:04:01 +0200
> 
> Eli Zaretskii <[email protected]> writes:
> 
> >> --8<---------------cut here---------------start------------->8---
> >> make -C test filenotify-tests SELECTOR='$(SELECTOR_DEFAULT)'
> >> --8<---------------cut here---------------end--------------->8---
> >> 
> >> runs a restricted set of the tests only.
> >
> > I'm talking about the default.  I just ran "filenotify-tests", without
> > any selectors.  Shouldn't that by default avoid too-long tests?
> 
> That was discussed years ago, when we have introduced the different
> SELECT_* variables in test/Makefile. The most common use case for 'make
> <filename>' is for developers, checking their package. It makes sense to
> run expensive tests in this case, so I don't like to change it.

So you are saying that "make check" would skip those tests, but
"make SPECIFIC-tests" would not, is that right?

My problem here is that I rarely run the whole test suite, but very
frequently run specific tests, especially when some code or some test
has changed -- to verify it still succeeds.  That's what happened in
this case as well: I've run filenotify-tests because I've seen your
changes in them.

> What we could think about is a configurable preference, which SELECTOR_*
> variable to apply for 'make <filename>' by default. A 'configure'
> option?

Is it frequent to run "make <filename>" with the intent to run all of
the tests in <filename>, even the expensive and unstable ones?