Re: Eglot tests fail on emba
Michael Albinus <[email protected]>
| Newsgroups | gmane.emacs.devel |
|---|---|
| Message-ID | <[email protected]> |
João Távora <[email protected]> writes: > Hi Michael, Hi João, > I'll not be in front of a laptop for about two weeks, so you'll have > to debug this yourself or enlist others to help you. I suspect this > affects not only the tests but actual Eglot usage by whomever is > building Emacs from trunk, which IME is a non-negligible group of > people. > > Maybe Eglot does some less than optimal usage of file notification > watchers, and I'm happy to take a look at it when I come back and put > in a perfectly tested and safe backward-compatible patch to eglot.el > that works both with master and older Emacs < 32 down to Emacs 26.3. > If no one beats me to it if course (which unfortunately is unlikely > IME). Use of file notification itself doesn't seem to break eglot, as much as I understand. There are two questions: - Why does file notification speaks about creation of .#main.rs now? This file wasn't mentioned before, and I don't understand where it comes from. - Which process sentinel is it that the broken test speaks abouut? --8<---------------cut here---------------start------------->8--- error in process sentinel: Process EGLOT (on-type-formatting-project/(rust-mode)) not running: finished --8<---------------cut here---------------end--------------->8--- file notification doesn't use processes. I have no idea where to get the answer, and I believe somebody with eglot knowledge should be involved. > Then either fix Eglot (again, if you're confident and can give it some > testing somehow and it's backward compatible to older versions of > Emacs, as I explained above) or revert/fix that bit of your change > inside your commit. Is your change to filenotify.el urgent, or somehow > laying essential groundwork for other changes? I won't revert the change until I know what's up. > João Best regards, Michael.