Re: master 49f3888c5dc: Add new options to 'query-replace-show-preview' (bug#81583)

Juri Linkov [24/Aug 11:36am -04] wrote:
> branch: master
> commit 49f3888c5dc6d139f9ab9bcd12994f9d0e9110ea
> Author: Rahul Martim Juliato <[email protected]>
> Commit: Juri Linkov <[email protected]>
>
>     Add new options to 'query-replace-show-preview' (bug#81583)
>
>     * lisp/replace.el (query-replace-show-preview): Accept 'both'
>     and a function of two arguments as values.  Doc fix.
>     (query-replace-preview-match): New face.
>     (replace-preview--propertize, replace-preview--format): New
>     functions.
>     (replace-preview-update): Use 'replace-preview--format'.
>     * etc/NEWS: Update the entry.

With these user options with multiple possibilities, where there isn't a
backwards compatibility issue to consider (as there isn't here), it's
nice to make it so that `t' turns on all the features and the other
values turn them on partially.  Then there is a natural ordering
nil->something->other->t.

So could we perhaps make `t' mean `both' and use another symbol for when
only the result is displayed?

-- 
Sean Whitton