Re: Eglot tests fail on emba
João Távora <[email protected]>
| Newsgroups | gmane.emacs.devel |
|---|---|
| Message-ID | <CALDnm52rWkV8Ysk13UH4cPyDW185yDMo3BLYwo02iJQcJ5qxvA@mail.gmail.com> |
On Wed, Aug 26, 2026, 15:33 Michael Albinus <[email protected]> wrote: > > > You know you broke something. You don't know exactly what you broke, > > and you definitely didn't do it on purpose. And that happens, it's a > > part of dev life. Happens to me all the time. But it's pretty clear > > your actions, not anyone else's, are responsible for this breakage. > > Act in accordance with this established fact. > > Perhaps there is a bug in my change. But maybe, it is just a bug lying > around not in file notification, which was uncovered by the slighly > changed race conditions in file notification? We don't know this. > Agree. The bug may even have been in Eglot all along, and filenotify was just tolerant of it. But that doesn't mean that a user-facing problem that didn't exist before (for 6 major versions) should be kept around until developers sort it out. This is obvious to me. > Also, have you tried my suggestion to micro-bisect your change, the > > commit I pointed to, and which we know broke things? I think it could > > yield insight! > > Running eglot-tests interactively doesn't show a problem: all tests > pass. That's a good sign, but it isn't a 100% safe proxy for "problem never actually reaches users". And yes, I have done this in the VM created with emba environment. > That's not what I meant by "micro-bisecting your change". I guess I can't explain it to you... So there is no emergency: we can wait until you return, and have time > for checks. > Let's hope indeed problem doesn't reach users. João