Re: master d423017cae1: * lisp/vc/vc-dir.el (vc-dir-headers): Try a hints separator line.

Dmitry Gutov <[email protected]> writes:

[...]

> Speaking of reviewing, we now have 3 uses without extra surrounding 
> newlines, and 3 uses with them. This removes them consistently, I think:
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index 16e9ba04f3c..92247b35ec2 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -3041,7 +3041,7 @@ describe-package-1
>
>         ;; Insert news if available.
>         (when news
> -        (insert "\n" (make-separator-line) "\n"
> +        (insert (make-separator-line)
>                   (propertize "* News" 'face 'package-help-section-name)
>                   "\n\n")
>           (insert-file-contents news))
>
> diff --git a/lisp/help-fns.el b/lisp/help-fns.el
> index af5a64f9e9c..3fdbb11ce07 100644
> --- a/lisp/help-fns.el
> +++ b/lisp/help-fns.el
> @@ -2009,7 +2009,7 @@ describe-symbol
>                 (insert doc)
>                 (delete-region (point)
>                                (progn (skip-chars-backward " \t\n") 
> (point)))
> -              (insert "\n\n" (make-separator-line) "\n")
> +              (insert "\n" (make-separator-line))
>                 (when name
>                   (insert (symbol-name symbol)
>                           " is also a " name "." "\n\n"))))
> diff --git a/lisp/help.el b/lisp/help.el
> index be6e56ab646..c6667795094 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -1267,7 +1267,7 @@ describe-key
>             (when defn
>               (when (> (length info-list) 1)
>                 (with-current-buffer standard-output
> -                (insert "\n\n" (make-separator-line) "\n")))
> +                (insert "\n" (make-separator-line))))
>
>               (insert brief-desc)
>               (when locus
>
> I've tested how 2 out of 3 look, but not the package.el's one (can't 
> find a package with news for some reason) - Cc'ing Philip. The question 
> is just does it look okay.

You can just copy any file you want into the root directory of the ELPA
package and call it "NEWS-elpa".

One thing I'd like to add in case it hasn't been brought up, because I
remember this influencing me when I wrote the code, is that the
appearance of the separator line differs depending on the theme.  If you
load a modus theme, for instance, then you'll get more padding above the
line.