Re: Interactive mode tagging for locate.el, timer-list.el, and chistory.el

Ahmed Mohamed via "Emacs development discussions." <[email protected]>
Newsgroups gmane.emacs.devel
Message-ID <[email protected]>
Hi Philip,

I see. In the TODO it says to email first to see if other people are 
already working on it,

but these are small changes. Attached is the first patch.



Ahmed Mohamed
[email protected] | ahmh.dev <https://ahmh.dev>

On Sun, Aug 30, 2026 at 10:58 AM, Philip Kaludercic <[email protected]> 
wrote:
> Ahmed Mohamed<[email protected]> writes:
>> Hello,
>>
>> I’d like to work on the “Do interactive mode tagging for commands”
>> item in etc/TODO.
>>
>> I found the following apparently mode-specific commands that remain
>> untagged:
>> - locate-mouse-view-file and locate-do-redisplay — locate-mode
>> - timer-list-cancel — timer-list-mode
>> - command-history-repeat — command-history-mode
>>
>> I plan to handle each library as a separate small patch. Is anyone
>> already working on these,
> You can never really know these things, so in practice you can assume
> that this is not the case.  (If someone is, the synchronization point
> will be when one of two patches has to be merged, at which point you can
> collaborate).
>
>>                            or are there any objections to these
>> particular mode tags?
> I am not familiar with this TODO item, but I don't think there would be
> any objections if they are listed in etc/TODO.  In general you don't
> have to ask for permission to work on something, it is best to be
> constructive and come with a concrete patch that we can discuss.  Of
> course if you have questions or problems, you can ask questions here!
>
> Other than that, happy hacking :)
>
>> Thanks,
>> Ahmed Mohamed
>> [email protected] | ahmh.dev<https://ahmh.dev>
0001-Tag-remaining-Locate-commands-with-locate-mode.patch (text/x-patch, 1.3 KB)
From c01629d7ca264c223da766046b062d36c457e679 Mon Sep 17 00:00:00 2001
From: Ahmed Mohamed <[email protected]>
Date: Mon, 31 Aug 2026 11:26:06 -0500
Subject: [PATCH] Tag remaining Locate commands with locate-mode

* lisp/locate.el (locate-mouse-view-file, locate-do-redisplay):
Mark as specific to locate-mode.

Copyright-paperwork-exempt: yes
---
 lisp/locate.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/locate.el b/lisp/locate.el
index fc0d015..0acf53f 100644
--- a/lisp/locate.el
+++ b/lisp/locate.el
@@ -426,7 +426,7 @@ file name or is inside a subdirectory."
 
 (defun locate-mouse-view-file (event)
   "In Locate mode, view a file, using the mouse."
-  (interactive "@e")
+  (interactive "@e" locate-mode)
   (save-excursion
     (goto-char (posn-point (event-start event)))
     (if (locate-main-listing-line-p)
@@ -665,7 +665,7 @@ the database on the command line."
 
 (defun locate-do-redisplay (&optional arg test-for-subdir)
   "Like `dired-do-redisplay', but adapted for `*Locate*' buffers."
-  (interactive "P\np")
+  (interactive "P\np" locate-mode)
   (if (string= (dired-current-directory) "/")
       (message "This command only works in subdirectories.")
     (let ((dired-actual-switches locate-ls-subdir-switches))
-- 
2.55.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.