Re: master 23a5ae5a245 2/2: vc-dir: Position point initially below the binding hints area

Dmitry Gutov <[email protected]> writes:

Hi Dmitry,

>     vc-dir: Position point initially below the binding hints area
>     
>     * lisp/vc/vc-dir.el (vc-dir-refresh): Move point to the line after
>     the separator.  This way the hints are emphasized as separate.

This breaks vc-test-misc.el:

--8<---------------cut here---------------start------------->8---
# make -C test vc-test-misc
Test vc-test-vc-dir-next/previous backtrace:
  signal(ert-test-failed (((should (bobp)) :form (bobp) :value nil)))
  ert-fail(((should (bobp)) :form (bobp) :value nil))
  (if (unwind-protect (setq value-260 (apply fn-258 args-259)) (setq f
  (let (form-description-262) (if (unwind-protect (setq value-260 (app
  (let ((value-260 'ert-form-evaluation-aborted-261)) (let (form-descr
  (let* ((fn-258 #'bobp) (args-259 (condition-case err (list) (error (
  (let ((default-directory tempdir) (n 0) vc-dir-buf) (vc-test--create
  (progn (let ((default-directory tempdir) (n 0) vc-dir-buf) (vc-test-
  (unwind-protect (progn (let ((default-directory tempdir) (n 0) vc-di
  (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
  (let ((vc-handled-backends '(Git))) (let* ((coding-system-for-write 
  (let ((process-environment process-environment) (vc-hg-global-switch
  #f(lambda () [vc-sentinel-movepoint vc-hg-global-switches t] (let* (
  #f(compiled-function () #<bytecode 0x17993a02f449bf9d>)()
  handler-bind-1(#f(compiled-function () #<bytecode 0x17993a02f449bf9d
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name vc-test-vc-dir-next/previous :documen
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test vc-test-vc-dir-next/previous condition:
    (ert-test-failed ((should (bobp)) :form (bobp) :value nil))
   FAILED  18/20  vc-test-vc-dir-next/previous (0.091259 sec) at lisp/vc/vc-tests/vc-test-misc.el:301
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.