Re: master 6698677f0d3: ; vc-dir-refresh: Predicate the last change on not being in revert-buffer

>     ; vc-dir-refresh: Predicate the last change on not being in revert-buffer
> ---
>  lisp/vc/vc-dir.el | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
> index c9cafa3cba4..b6ba3cb02a9 100644
> --- a/lisp/vc/vc-dir.el
> +++ b/lisp/vc/vc-dir.el
> @@ -1836,8 +1836,9 @@ Throw an error if another update process is in progress."
>        ;; Bzr has serious locking problems, so setup the headers first (this is
>        ;; mostly synchronous) rather than doing it while dir-status is running.
>        (vc-dir--set-header def-dir 'reset-footer)
> -      (when vc-dir-show-key-binding-hints
> -        (goto-char (1+ (length vc-dir--key-binding-hints))))
> +      (unless revert-buffer-in-progress
> +        (when vc-dir-show-key-binding-hints
> +          (goto-char (1+ (length vc-dir--key-binding-hints)))))

This counts as a code smell for me, so I'd appreciate if you could add
a comment that describes the case that this is intended to fix.


=== Stefan