Re: [ELPA] New package: markdown-ts-appear

强生 <[email protected]> writes:

> Hello,
>
> I would like to submit markdown-ts-appear to NonGNU ELPA.
>
> markdown-ts-appear is a minor mode for Emacs 31's built-in
> markdown-ts-mode. It hides Markdown markup while reading and reveals
> the smallest semantic element at point while editing. It also provides
> optional asynchronous MathJax previews and visual decorations for code
> blocks, callouts, block quotes, links, and tables.
>
> Repository:
> https://github.com/Thysrael/markdown-ts-appear

As the code is AI generated, I'll just leave a few high level comments:

- You don't need the :group annotations in user options, they fall back
  to the last defgroup.

- Can you set the default value of
  `markdown-ts-appear-enable-math-preview' to be (package-installed-p
  'Mathias)?

- The logic do draw a box around a code block uses these BOX DRAWINGS
  characters that don't always look good with all fonts.  I would
  recommend re-thinking this, or just plain avoiding using text to draw.

Otherwise the code seems OK from a skim, albeit very verbose.  I cannot
judge just from reading (and cannot test it since I don't build Emacs
with tree sitter) but I have difficulties believing that the entire 2400
lines of code are all there to match the necessary complexity of the
problem you are trying to solve.  Please keep in mind that just because
you use an LLM, doesn't mean that humans don't want to read and change
the code as well without being exhausted, so it valuable to keep the
codebase "human sized".

Other than that I have CC'ed the markdown-ts-mode maintainers Stephane
and Rahul for further comments.  Sadly the features of this package are
currently not candidates for upstreaming, but perhaps they have a better
feeling if the package suggestion makes sense in the current form.
Specifically I would be interested if we could avoid the advice block at
the end of the file.

> The main Lisp file is located at the repository root, and the default
> branch should be tracked. No special build commands are required.

You can also add a .elpaignore file to exclude the examples/ and test/
directory from the release tarballs.

> I am the author and maintainer.
>
> Regards,
> Thysrael