master 5fda2f63ffa 2/4: Flymake: more adjustments to inline diagnostics

branch: master
commit 5fda2f63ffa782f9836defc77183bd5a0b172c21
Author: João Távora <[email protected]>
Commit: João Távora <[email protected]>

    Flymake: more adjustments to inline diagnostics
    
    * lisp/progmodes/flymake.el (flymake--highlight-line): Simplify
    eol overlay cleanup logic.
---
 lisp/progmodes/flymake.el | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 7ec6fd52889..8bc3dc3e4f3 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -986,11 +986,6 @@ Return nil or the overlay created."
     ;;
     (overlay-put ov 'evaporate t)
     (overlay-put ov 'flymake-overlay t)
-    (overlay-put ov 'modification-hooks
-                 `(,(lambda (ov after &rest _)
-                      (when-let* ((eolov
-                                   (and (null after) (overlay-get ov 'flymake--eol-ov))))
-                        (delete-overlay eolov)))))
     (overlay-put ov 'flymake-diagnostic diagnostic)
     ;; Handle `flymake-show-diagnostics-at-end-of-line'
     ;;
@@ -1011,7 +1006,8 @@ Return nil or the overlay created."
             (overlay-put eolov 'flymake-overlay t)
             (overlay-put eolov 'flymake--eol-overlay t)
             (overlay-put eolov 'flymake-eol-source-overlays (list ov))
-            (overlay-put eolov 'evaporate (not (= start end)))) ; FIXME: fishy
+            ;; FIXME: next line fishy, should be just t
+            (overlay-put eolov 'evaporate (not (= start end))))
           (overlay-put ov 'flymake--eol-ov eolov))))
     ov))