Re: [PATCH 1/1] emms-source-playlist.el: add native playlist to cache

Leo Okawa Ericson <[email protected]> writes:

> I think I missed sending this to the list when I last tried to reply, so
> I'm resending this:

...and now I've applied it to the main git repo; thank you.
https://git.savannah.gnu.org/cgit/emms.git/commit/?id=c83157d9707cc84fc9bbbd8b330484850044a4f5

People should use it for a bit, and then it can go out on the next
release.

I've also added you to the AUTHORS file, but only under the so-called
"trivial" section at the moment:
https://git.savannah.gnu.org/cgit/emms.git/commit/?id=f008e996d41c8052fd23d34cc81bf6ddd26e76ff

However, as far as I can see you have a copyright assignment in place
for Emacs, so if you want to write more code for Emms you are all set.


> Yoni Rabkin <[email protected]> writes:
>
>> I don't see a problem with the patch in and of itself. But if some
>> tracks were saved as a native playlist, doesn't that mean that they were
>> already loaded and therefore already in the cache?
>
> I don't know if tracks played by `emms-play-url` get saved in the cache,
> but those are the cases I'm interested in.
>
>> Are you referring a case where you import an Emms native playlist to an
>> instance that has never seen those tracks before. Do I understand the
>> use-case correctly?
>
> Yes I think so.  I have some playlists that are hosted on the web that I
> play with mpv, so I've created native playslists by saving the playlist
> and adding metadata manually.  Something like this:
>
> ;;; This is an EMMS playlist file Play it with M-x emms-play-playlist
> ((*track* (type . url)
>           (name . "https://www.youtube.com/watch?v=fsTtegev-eA")
>           (info-albumartist . "The Dear Hunter")
>           (info-year . "2013")
>           (info-album . "Migrant")
>           (info-tracknumber . "1")
>           (info-artist . "The Dear Hunter")
>           (info-title . "Migrant")))
>
> Which I then call `emms-add-playlist` so that they show up in `emms-browser`.
>

-- 
   "Cut your own wood and it will warm you twice"