Re: A couple small patches

Yoni Rabkin <[email protected]>
Newsgroups gmane.emacs.emms.user
Message-ID <[email protected]>
Morgan Smith <[email protected]> writes:

> Hello!
>
> I have a couple tiny patches that are hopefully all self explanatory.
> Let me know what you think.

I've applied all three. I personally don't like doing work in a :set
function, but I understand that it's a perfectly valid way of doing
things (and that I'm an old curmudgeon). The Elisp manual says that:

     """ If you specify this keyword [:set], the variable’s
     documentation string should describe how to do the same job in
     hand-written Lisp code, either by invoking SETFUNCTION directly or
     by using ‘setopt’."""

No need to do that in this case, but it underlines why I'm generally
wary of splitting code between functions and customizable variables.

Thank you for your patches!

-- 
   "Cut your own wood and it will warm you twice"
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.