bug#48598: 28.0.50; buffer-naming collisions involving bouncers in ERC

"J.P." <[email protected]>
Newsgroups gmane.emacs.bugs,gmane.emacs.erc.general
Message-ID <[email protected]>
Lars Ingebrigtsen <[email protected]> writes:

> Michael Albinus <[email protected]> writes:
>
>> On EMBA, tests will run only per subdirectories like test/lisp/erc. As
>> long as all ERC related tests are located there, these tests are
>> triggered only when there is a change in lisp/erc/* or
>> test/lisp/erc/*. No problem.

Thanks for the lowdown, Michael. The tests that matter live directly
under test/lisp/erc. The deeper ones

  test/lisp/erc
  ├── erc-d
  │   ├── erc-d-self.el   <~~ like this thing

only target fixtures and other apparati, so they can be skipped if need
be. But if they're swept up for the bigger 8-hourly runs, that's fine
too.

> If these tests take five minutes, then they're presumably marked as
> expensive, so they won't get run by a normal "make check" anyway?  (I
> haven't actually checked the patch.)

Lars, thanks for looking at this (and my other bugs). I meant five
minutes in aggregate. The vast majority take fractions of a second, and
the ones that don't mostly reside in a single file (log attached). I
haven't yet tagged any as expensive but certainly can. CONTRIBUTE says
"longer than some few seconds", so I guess maybe a dozen or so in that
EMBA log fit the bill. Should I go ahead and tag them?
erc-scenarios.log (text/plain, 4.8 KB)
Running 59 tests (2022-04-09 02:47:07+0000, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))')
   passed   1/59  erc-scenarios-aux-unix-socket (1.154740 sec)
   passed   2/59  erc-scenarios-base-association-bouncer-history (4.083658 sec)
   passed   3/59  erc-scenarios-base-association-multi-net--ambiguous-join (2.164876 sec)
   passed   4/59  erc-scenarios-base-association-multi-net--baseline (1.790335 sec)
   passed   5/59  erc-scenarios-base-association-nick-bumped (2.620571 sec)
   passed   6/59  erc-scenarios-base-association-nick-bumped-mandated-renick (2.354076 sec)
   passed   7/59  erc-scenarios-base-association-reconnect-playback (3.130082 sec)
   passed   8/59  erc-scenarios-base-association-same-network--new-buffer (1.467410 sec)
   passed   9/59  erc-scenarios-base-association-same-network--reconnect-one (1.543708 sec)
   passed  10/59  erc-scenarios-base-auth-source--dialed (0.370551 sec)
   passed  11/59  erc-scenarios-base-auth-source--dialed-fallback (0.336897 sec)
   passed  12/59  erc-scenarios-base-auth-source--network-id (0.335128 sec)
   passed  13/59  erc-scenarios-base-auth-source--nopass (0.230926 sec)
   passed  14/59  erc-scenarios-base-auth-source--nopass--network-id (0.298571 sec)
   passed  15/59  erc-scenarios-base-auth-source--string--network-id (0.416198 sec)
   passed  16/59  erc-scenarios-base-channel-buffer-revival (8.840853 sec)
   passed  17/59  erc-scenarios-base-compat-no-rename-bouncer--basic (3.519682 sec)
   passed  18/59  erc-scenarios-base-compat-no-rename-bouncer--reconnect (7.593708 sec)
   passed  19/59  erc-scenarios-base-flood (4.681115 sec)
   passed  20/59  erc-scenarios-base-gapless-connect (5.045632 sec)
   passed  21/59  erc-scenarios-base-legacy-autojoin--announced (1.235518 sec)
   passed  22/59  erc-scenarios-base-mask-target-routing (4.638258 sec)
   passed  23/59  erc-scenarios-base-network-id-bouncer--base (3.469371 sec)
   passed  24/59  erc-scenarios-base-network-id-bouncer--both (3.550288 sec)
   passed  25/59  erc-scenarios-base-network-id-bouncer--id-bar (3.329161 sec)
   passed  26/59  erc-scenarios-base-network-id-bouncer--id-foo (3.347604 sec)
   passed  27/59  erc-scenarios-base-network-id-bouncer--reconnect-base (7.505730 sec)
   passed  28/59  erc-scenarios-base-network-id-bouncer--reconnect-both (7.515326 sec)
   passed  29/59  erc-scenarios-base-network-id-bouncer--reconnect-id-bar (7.541407 sec)
   passed  30/59  erc-scenarios-base-network-id-bouncer--reconnect-id-foo (7.829000 sec)
   passed  31/59  erc-scenarios-base-network-id-same-network--no-ids (2.631339 sec)
   passed  32/59  erc-scenarios-base-network-id-same-network--one-id-chester (2.649168 sec)
   passed  33/59  erc-scenarios-base-network-id-same-network--one-id-tester (2.748441 sec)
   passed  34/59  erc-scenarios-base-network-id-same-network--two-ids (2.525411 sec)
   passed  35/59  erc-scenarios-base-reconnect-options--bury (4.993197 sec)
   passed  36/59  erc-scenarios-base-reconnect-options--default (2.593625 sec)
   passed  37/59  erc-scenarios-base-reconnect-timer (3.869136 sec)
   passed  38/59  erc-scenarios-base-renick-queries-bouncer (2.421547 sec)
   passed  39/59  erc-scenarios-base-renick-queries-solo (2.279074 sec)
   passed  40/59  erc-scenarios-base-renick-self-auto (0.753712 sec)
   passed  41/59  erc-scenarios-base-renick-self-manual (1.270642 sec)
   passed  42/59  erc-scenarios-base-renick-self-qualified (2.176443 sec)
   passed  43/59  erc-scenarios-base-reuse-buffers-channel-buffers--disabled (3.240807 sec)
   passed  44/59  erc-scenarios-base-reuse-buffers-server-buffers--disabled (0.757688 sec)
   passed  45/59  erc-scenarios-base-reuse-buffers-server-buffers--enabled (0.414566 sec)
   passed  46/59  erc-scenarios-join-network-id--cmd-reconnect (6.679735 sec)
   passed  47/59  erc-scenarios-join-network-id--cmd-reconnect-id (6.646426 sec)
   passed  48/59  erc-scenarios-join-network-id--cmd-reconnect-ids (6.623370 sec)
   passed  49/59  erc-scenarios-join-network-id--new-invocation (6.665379 sec)
   passed  50/59  erc-scenarios-join-network-id--new-invocation-id (6.631752 sec)
   passed  51/59  erc-scenarios-join-network-id--new-invocation-ids (6.461279 sec)
   passed  52/59  erc-scenarios-join-reconnect (2.915173 sec)
   passed  53/59  erc-scenarios-networks-announced-missing (0.298282 sec)
   passed  54/59  erc-scenarios-services-auth-source--announced (2.479631 sec)
   passed  55/59  erc-scenarios-services-auth-source--dialed (2.440358 sec)
   passed  56/59  erc-scenarios-services-auth-source--network (2.402855 sec)
   passed  57/59  erc-scenarios-services-auth-source--network-connect-lookup (2.579627 sec)
   passed  58/59  erc-scenarios-services-password (2.368437 sec)
   passed  59/59  erc-scenarios-services-prompt (2.542709 sec)

Ran 59 tests, 59 results as expected, 0 unexpected (2022-04-09 02:50:22+0000, 195.023808 sec)
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.