Re: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt
Eli Zaretskii <[email protected]> Fri, 12 Jan 2024 14:08:18 +0200
| Newsgroups | gmane.emacs.erc.general |
|---|---|
| Message-ID | <[email protected]> |
> Cc: [email protected] > From: Emanuel Berg <[email protected]> > Tags: patch > Date: Fri, 12 Jan 2024 11:43:05 +0100 > > Patch without whitespace changes. It still lacks a log message according to our conventions. > >From a2345b8eb22af2d5a052c1e22a19aeffc48544b2 Mon Sep 17 00:00:00 2001 > From: Emanuel Berg <[email protected]> > Date: Fri, 12 Jan 2024 11:37:28 +0100 > Subject: [PATCH] `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. This only gives the header line of a commit log message, but the "meat" is missing. Here's a random example of a valid commit log message (you can see more by typing "git log" from the shell prompt or "C-x v L" inside Emacs): Implement missing functions for custom-icon widget * lisp/cus-edit.el (custom-icon-reset-saved, custom-icon-mark-to-save) (custom-icon-state-set-and-redraw, custom-icon-reset-standard) (custom-icon-mark-to-reset-standard): New functions. (custom-icon, custom-icon-extended-menu): Register and add them to the menu. (Bug#66947) See CONTRIBUTE for more information about our conventions in this regard. > -(defun erc-cmd-AMSG (line) > - "Send LINE to all channels of the current server that you are on." > - (interactive "sSend to all channels you're on: ") > +(defun erc-cmd-GMSG (line) > + "Send LINE to all channels on all networks you are on." > + (interactive "sSend to all channels: ") Our style is also to mention the interactive prompts in the doc string: "Send LINE to all channels on all networks you are on. Interactively, prompt for the line of text to send." > +(defun erc-cmd-AMSG (line) > + "Send LINE to all channels of the current network." Same here. > +(defun erc-cmd-GME (line) > + "Send LINE as an action to all channels on all networks you are on." And here. > +(defun erc-cmd-AME (line) > + "Send LINE as an action to all channels on the current network." And here. Thanks.