Changes committed gnus/lisp (ChangeLog mml.el)

"Katsumi Yamaoka" <[email protected]> Fri, 28 Aug 2009 12:57:24 +0200
Newsgroups gmane.emacs.gnus.commits
Message-ID <[email protected]>
Modified: ChangeLog mml.el

(mml-attach-file, mml-attach-buffer, mml-attach-external): Don't save excursion.


Index: ChangeLog
diff -u gnus/lisp/ChangeLog:7.2006 gnus/lisp/ChangeLog:7.2007
--- ChangeLog:7.2006	Wed Aug 12 10:27:50 2009
+++ ChangeLog	Fri Aug 28 12:57:24 2009
@@ -1,3 +1,8 @@
+2009-08-28  Katsumi Yamaoka  <[email protected]>
+
+	* mml.el (mml-attach-file, mml-attach-buffer, mml-attach-external):
+	Don't save excursion.
+
 2009-08-12  Katsumi Yamaoka  <[email protected]>
 
 	* gnus-group.el (gnus-safe-html-newsgroups): New user option.
Index: mml.el
diff -u gnus/lisp/mml.el:7.75 gnus/lisp/mml.el:7.76
--- mml.el:7.75	Tue Mar  3 00:27:36 2009
+++ mml.el	Fri Aug 28 12:57:24 2009
@@ -1292,15 +1292,14 @@
 	  (description (mml-minibuffer-read-description))
 	  (disposition (mml-minibuffer-read-disposition type nil file)))
      (list file type description disposition)))
-  (save-excursion
-    (unless (message-in-body-p) (goto-char (point-max)))
-    (mml-insert-empty-tag 'part
-			  'type type
-			  ;; icicles redefines read-file-name and returns a
-			  ;; string w/ text properties :-/
-			  'filename (mm-substring-no-properties file)
-			  'disposition (or disposition "attachment")
-			  'description description)))
+  (unless (message-in-body-p) (goto-char (point-max)))
+  (mml-insert-empty-tag 'part
+			'type type
+			;; icicles redefines read-file-name and returns a
+			;; string w/ text properties :-/
+			'filename (mm-substring-no-properties file)
+			'disposition (or disposition "attachment")
+			'description description))
 
 (defun mml-dnd-attach-file (uri action)
   "Attach a drag and drop file.
@@ -1336,11 +1335,10 @@
 	  (description (mml-minibuffer-read-description))
 	  (disposition (mml-minibuffer-read-disposition type nil)))
      (list buffer type description disposition)))
-  (save-excursion
-    (unless (message-in-body-p) (goto-char (point-max)))
-    (mml-insert-empty-tag 'part 'type type 'buffer buffer
-			  'disposition disposition
-			  'description description)))
+  (unless (message-in-body-p) (goto-char (point-max)))
+  (mml-insert-empty-tag 'part 'type type 'buffer buffer
+			'disposition disposition
+			'description description))
 
 (defun mml-attach-external (file &optional type description)
   "Attach an external file into the buffer.
@@ -1351,10 +1349,9 @@
 	  (type (mml-minibuffer-read-type file))
 	  (description (mml-minibuffer-read-description)))
      (list file type description)))
-  (save-excursion
-    (unless (message-in-body-p) (goto-char (point-max)))
-    (mml-insert-empty-tag 'external 'type type 'name file
-			  'disposition "attachment" 'description description)))
+  (unless (message-in-body-p) (goto-char (point-max)))
+  (mml-insert-empty-tag 'external 'type type 'name file
+			'disposition "attachment" 'description description))
 
 (defun mml-insert-multipart (&optional type)
   (interactive (list (completing-read "Multipart type (default mixed): "