[gnus git] branch master updated: m0-11-27-g15e4ea3 =1= html2text.el (html2text-get-attr): Rewrite to handle spaces in quoted attribute values (Bug#17834)

       via  15e4ea3b34700d6b7cd02d2ef69bd3913bbdb75d (commit)
      from  7221d796a717d25fc3219f61ac34c867ed4f88c6 (commit)


- Log -----------------------------------------------------------------
commit 15e4ea3b34700d6b7cd02d2ef69bd3913bbdb75d
Author: Andreas Schwab <[email protected]>
Date:   Tue Jun 24 22:11:06 2014 +0000

    html2text.el (html2text-get-attr): Rewrite to handle spaces in quoted attribute values (Bug#17834)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index b71e91c..3f79e8c 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2014-06-24  Andreas Schwab  <[email protected]>
+
+	* html2text.el (html2text-get-attr): Rewrite to handle spaces in quoted
+	attribute values.  (Bug#17834)
+
 2013-06-22  Dmitry Antipov  <[email protected]>
 
 	* gnus-sum.el (gnus-summary-edit-article-done):
diff --git a/lisp/html2text.el b/lisp/html2text.el
index 78cecd9..22ee1c3 100644
--- a/lisp/html2text.el
+++ b/lisp/html2text.el
@@ -179,72 +179,20 @@ formatting, and then moved afterward.")
 
 (defun html2text-get-attr (p1 p2)
   (goto-char p1)
-  (re-search-forward " +[^ ]" p2 t)
-  (let* ((attr-string (buffer-substring-no-properties (1- (point)) (1- p2)))
-	 (tmp-list (split-string attr-string))
-	 (attr-list)
-	 (counter 0)
-	 (prev (car tmp-list))
-	 (this (nth 1 tmp-list))
-	 (next (nth 2 tmp-list))
-	 (index 1))
-
-    (cond
-     ;; size=3
-     ((string-match "[^ ]=[^ ]" prev)
-      (let ((attr  (nth 0 (split-string prev "=")))
-	    (value (substring prev (1+ (string-match "=" prev)))))
-	(setq attr-list (cons (list attr value) attr-list))))
-     ;; size= 3
-     ((string-match "[^ ]=\\'" prev)
-      (setq attr-list (cons (list (substring prev 0 -1) this) attr-list))))
-
-    (while (< index (length tmp-list))
-      (cond
-       ;; size=3
-       ((string-match "[^ ]=[^ ]" this)
-	(let ((attr  (nth 0 (split-string this "=")))
-	      (value (substring this (1+ (string-match "=" this)))))
-	  (setq attr-list (cons (list attr value) attr-list))))
-       ;; size =3
-       ((string-match "\\`=[^ ]" this)
-	(setq attr-list (cons (list prev (substring this 1)) attr-list)))
-       ;; size= 3
-       ((string-match "[^ ]=\\'" this)
-	(setq attr-list (cons (list (substring this 0 -1) next) attr-list)))
-       ;; size = 3
-       ((string= "=" this)
-	(setq attr-list (cons (list prev next) attr-list))))
-      (setq index (1+ index))
-      (setq prev this)
-      (setq this next)
-      (setq next (nth (1+ index) tmp-list)))
-    ;;
-    ;; Tags with no accompanying "=" i.e. value=nil
-    ;;
-    (setq prev (car tmp-list))
-    (setq this (nth 1 tmp-list))
-    (setq next (nth 2 tmp-list))
-    (setq index 1)
-
-    (when (and (not (string-match "=" prev))
-	       (not (string= (substring this 0 1) "=")))
-      (setq attr-list (cons (list prev nil) attr-list)))
-    (while (< index (1- (length tmp-list)))
-      (when (and (not (string-match "=" this))
-		 (not (or (string= (substring next 0 1) "=")
-			  (string= (substring prev -1) "="))))
-	(setq attr-list (cons (list this nil) attr-list)))
-      (setq index (1+ index))
-      (setq prev this)
-      (setq this next)
-      (setq next (nth (1+ index) tmp-list)))
-
-    (when (and this
-	       (not (string-match "=" this))
-	       (not (string= (substring prev -1) "=")))
-      (setq attr-list (cons (list this nil) attr-list)))
-    ;; return - value
+  (re-search-forward "\\s-+" p2 t)
+  (let (attr-list)
+    (while (re-search-forward "[-a-z0-9._]+" p2 t)
+      (setq attr-list
+	    (cons
+	     (list (match-string 0)
+		   (when (looking-at "\\s-*=")
+		     (goto-char (match-end 0))
+		     (skip-chars-forward "[:space:]")
+		     (when (or (looking-at "\"[^\"]*\"\\|'[^']*'")
+			       (looking-at "[-a-z0-9._:]+"))
+		       (goto-char (match-end 0))
+		       (match-string 0))))
+	     attr-list)))
     attr-list))
 
 ;;

-----------------------------------------------------------------------
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we listed those
revisions in full, above.

Summary of changes:
 lisp/ChangeLog    |    5 ++++
 lisp/html2text.el |   80 ++++++++++-------------------------------------------
 2 files changed, 19 insertions(+), 66 deletions(-)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnus Project".

The branch, master has been updated


hooks/post-receive
-- 
Gnus Project