[gnus git] branch master updated: m0-13-119-g9cfafae =1= Remove some useless-use-of eval

Katsumi Yamaoka <[email protected]> Fri, 29 Jan 2016 06:00:33 +0100
Newsgroups gmane.emacs.gnus.cvs
Message-ID <[email protected]>
       via  9cfafae1615983b82ea03c78dcb19f82b8b80f86 (commit)
      from  22733a495fc49c7fed924c50eb824a4cfb940f8d (commit)


- Log -----------------------------------------------------------------
commit 9cfafae1615983b82ea03c78dcb19f82b8b80f86
Author: Glenn Morris <[email protected]>
Date:   Fri Jan 29 05:00:24 2016 +0000

    Remove some useless-use-of eval
    
    * gnus.el (gnus-load-hook): Don't use eval.
    * nnrss.el (xml): Simply require it.
    (xml-rpc-method-call): Use declare-function.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index d416a55..d4b8dae 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,11 @@
+2016-01-29  Glenn Morris  <[email protected]>
+
+	Remove some useless-use-of eval.
+
+	* gnus.el (gnus-load-hook): Don't use eval.
+	* nnrss.el (xml): Simply require it.
+	(xml-rpc-method-call): Use declare-function.
+
 2016-01-25  Teodor Zlatanov  <[email protected]>
 
 	* gnus-art.el (gnus-blocked-images): Add explicit nil choice and tags.
diff --git a/lisp/gnus.el b/lisp/gnus.el
index 8e0e55a..98df559 100644
--- a/lisp/gnus.el
+++ b/lisp/gnus.el
@@ -26,7 +26,7 @@
 
 ;;; Code:
 
-(eval '(run-hooks 'gnus-load-hook))
+(run-hooks 'gnus-load-hook)
 
 (eval-when-compile (require 'cl))
 (require 'wid-edit)
diff --git a/lisp/nnrss.el b/lisp/nnrss.el
index c17a13c..bef8203 100644
--- a/lisp/nnrss.el
+++ b/lisp/nnrss.el
@@ -37,10 +37,7 @@
 (require 'mm-url)
 (require 'rfc2047)
 (require 'mml)
-(eval-when-compile
-  (ignore-errors
-   (require 'xml)))
-(eval '(require 'xml))
+(require 'xml)
 
 (nnoo-declare nnrss)
 
@@ -372,8 +369,6 @@ for decoding when the cdr that the data specify is not available.")
 (nnoo-define-skeleton nnrss)
 
 ;;; Internal functions
-(eval-when-compile (defun xml-rpc-method-call (&rest args)))
-
 (defun nnrss-get-encoding ()
   "Return an encoding attribute specified in the current xml contents.
 If `nnrss-compatible-encoding-alist' specifies the compatible encoding,
@@ -959,6 +954,9 @@ Use Mark Pilgrim's `ultra-liberal rss locator'."
 	      ;;    4. check syndic8
 	      (nnrss-find-rss-via-syndic8 url))))))))
 
+(declare-function xml-rpc-method-call "ext:xml-rpc"
+		  (server-url method &rest params))
+
 (defun nnrss-find-rss-via-syndic8 (url)
   "Query syndic8 for the rss feeds it has for URL."
   (if (not (locate-library "xml-rpc"))

-----------------------------------------------------------------------
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we listed those
revisions in full, above.

Summary of changes:
 lisp/ChangeLog |    8 ++++++++
 lisp/gnus.el   |    2 +-
 lisp/nnrss.el  |   10 ++++------
 3 files changed, 13 insertions(+), 7 deletions(-)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnus Project".

The branch, master has been updated


hooks/post-receive
-- 
Gnus Project