Re: [jdee-users] Using `define-derived-mode'
Paul Landes <[email protected]>
| Newsgroups | gmane.emacs.jdee.devel |
|---|---|
| Message-ID | <[email protected]> |
Ludovic Courtès writes: > Hello Paul, > > Paul Landes <[email protected]> writes: > > > Switching to derived mode is a pretty big change. Let's save this for > > a point release so we don't have too many (big) things changing for a > > release. > > It looked to me that there were very few changes in the source code. > The diffstat says this: > > jde/lisp/jde.el | 41 +++++++++++++++-------------------------- > 1 files changed, 15 insertions(+), 26 deletions(-) Not in terms of lines, but in terms of using a completely different method to create the mode. > But more importantly, I think it's an important bug-fix. See the > original bug report at http://thread.gmane.org/gmane.emacs.jdee.user/196 . > I believe it makes it hard to use JDE for anyone non-elisp savvy, and > it's a significant annoyance anyway. > > What do you think? Did you ever hit this problem? I haven't, but you're missing my point. I'm not saying I think it shouldn't go in but that we make a release just for this to nail down issues related to switching to it. > > Also, it isn't necessary for more than one person to copyright, and > > usually undesirable, a source code file per year. > > Per copyright laws, anyone contributing something "legally significant" > is a copyright holder. Copyright lines like this list copyright > holders, so it sounds right to me to add such lines for all contributors > (see, for example, source files in the Linux kernel: > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=kernel/audit.h;h=208687be4f30c8a2ddb432e3c1b8594fb85d2e8e;hb=894ef820b10d77e2d6d717342fc408bdd9825139 ). If we added a copyright for everyone that contributed patches, we'd have source code files that were more comments than code. I think it's more than sufficient for one contributor to put the copyright if it ever went to court--which is highly unlikely. > (I initially spotted this because my ~/.emacs contains > "(add-hook 'write-file-functions 'copyright-update)".) You might want to remove that for this project. -- Paul Landes [email protected] ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july