Re: Bugs introduced that affected jde-import-all (patch for last import has comment bug)
"Jeff Peck" <[email protected]>
| Newsgroups | gmane.emacs.jdee.devel |
|---|---|
| Message-ID | <8D00561E585143C783334A64607A5D3B@blue> |
The actual svn diff:
Index: lisp/jde-import.el
===================================================================
--- lisp/jde-import.el (revision 191)
+++ lisp/jde-import.el (working copy)
@@ -250,6 +250,9 @@
(setq insertion-point 1)))
(save-excursion
(goto-char insertion-point)
+ (unless (eolp)
+ (forward-line 1) ;skip any comment on last import line
+ (setq insertion-point (point)))
(unless (and (bolp) (eolp)) (insert "\n")))
insertion-point))
Note that if the parser would include "in-line" comments in the "import-tag" overlay,
this would not be a problem.
Looking into the more general failure to reparse, I find that inserting 'import ...;"
does not cause "semantic-changes-in-region" to come up true,
If I invoke (eval-expression '(semantic-parse-changes)) in the minibuffer,
then things are reparsed, and no multiple inserts.
But! If I try to run (semantic-parse-changes) using advice around/after jde-import-all,
(or even directly putting it into the end of jde-import-insert-imports-into-buffer)
it has no beneficial effect; it apparently sees no changes and makes no updates.
Maybe someone who understands how semantic reparse really works can explain...?
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
jdee-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jdee-devel