Re: Bugs introduced that affected jde-import-all

On Jan 8, 2010, at 3:15 PM, Jeff Peck wrote:

> Ok, i see, the repeated inserts are the side-effect that Len  
> mentioned when
> he checked in the "default to wisent-java"
> We need to find out why the buffer is not reparsed after the insert

I've had the reparsing problem for a very long time.  I think it is a  
bug with the old cedet and I have a feeling like a lot of these issues  
will be ironed out before we go to the next.  Maybe we should make the  
release after this the target for that.

> As fo the extra newlines, I tend to agree that adding new lines  
> should not
> be necessary.
> But the original code, given:
> --snip--
> import java.util.Map; // the last import
> --snip--
> will produce:
> --snip--
> import java.util.Map;
> // the last import
> --snip--
> And if you need to import HashMap, then it produces:
> --snip--
> import java.util.Map; import java.util.HashMap;
>
> //the last import
> --snip--

Yes, I agree, we don't ever want it to add new lines in code we don't  
put there, with some exception of some kind of pretty print  
functionality.  But I'm curious why you want to comment your imports.

> So the prior code is already inserting a newline, that is not  
> because of the
> patch.
> And as you see, it puts the newline (and any subsequent imports) in  
> the
> wrong place.

Outside of a newline where the import is inserted, why do you need to  
insert any new line on an import?


------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev