bug#3005: 23.0.92; w32term.c: width of hbar cursor on a wide character

Yu-ji Hosokawa <[email protected]>
Newsgroups gmane.emacs.bugs,gmane.emacs.pretest.bugs
Message-ID <[email protected]>
Hello,

The width of HBAR cursor on a wide character is narrower than the
character width.
On Emacs 22.3, HBAR cursor width and the underlying character width
were the same. It is a desirable view, I think.

I'm so sorry I'm poor in English. I worry about whether you
understand my English.
Please see attached image, "23_0_92.png" and "22_3.png".

If it is not intentional change, what about the patch below?

thanks,
--yu


$ cvs diff -pu src/w32term.c
Index: src/w32term.c
===================================================================
RCS file: /sources/emacs/emacs/src/w32term.c,v
retrieving revision 1.323
diff -p -u -r1.323 w32term.c
--- src/w32term.c       22 Mar 2009 02:39:30 -0000      1.323
+++ src/w32term.c       15 Apr 2009 22:10:02 -0000
@@ -5025,7 +5025,7 @@ x_draw_bar_cursor (w, row, width, kind)
          w32_fill_area (f, hdc, cursor_color, x,
                         WINDOW_TO_FRAME_PIXEL_Y (w, w->phys_cursor.y +
                                                  row->height - width),
-                        min (FRAME_COLUMN_WIDTH (f), cursor_glyph->pixel_width),
+                        cursor_glyph->pixel_width,
                         width);
        }



In GNU Emacs 23.0.92.1 (i386-mingw-nt5.1.2600)
 of 2009-04-16 on ASPIRIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -I/cygdrive/c/Users/yu-ji/src/GnuWin32/DLL'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: C
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: JPN
  value of $XMODIFIERS: nil
  locale-coding-system: cp932
  default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x r e p - e - b <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
23_0_92.png (image/png, 8.2 KB) - not displayed
22_3.png (image/png, 8.2 KB) - not displayed
sample_text.txt (text/plain, 261 B)
(emacs-version)
=> "GNU Emacs 23.0.92.1 (i386-mingw-nt5.1.2600)
 of 2009-04-15 on ASPIRIN"

(setq cursor-type '(hbar . 5))
=> (hbar . 5)

あいうえお あいうえお Japanese Hirakana
TAB	TAB
" " japanese-jisx0208 Japanese IDEOGRAPHIC SPACE #x3000
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.