bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared

Yavor Doganov <[email protected]>
Newsgroups gmane.emacs.bugs,gmane.emacs.pretest.bugs
Organization The GNU Emacs Church (Bulgarian eparchy)
Message-ID <87hby86lzd.GNU's_Not_Unix!%[email protected]>
Package: emacs,ns
Severity: serious
Tags: patch

The GNUstep port fails to build currently following this change:

2009-06-08  Adrian Robert  <[email protected]>

	Changes to support :script/:lang/:otf in NS font driver.
	...

I believe it's a bug in GNUstep GUI which I'll report to their
tracker.  For now, I suggest the workaround below.

What's worse is that the NSFontDescriptor class was implemented in GUI
0.13, while gNewSense DeltaH has 0.12.  Do you consider it important
enough to add a fallback code?


Changelog:

2009-06-22  Yavor Doganov  <[email protected]>

	* configure.in: Check for <AppKit/NSFontdescriptor.h>.

*** configure.in	22 юни 2009 22:30:12 +0300	1.599
--- configure.in	22 юни 2009 23:29:18 +0300	
***************
*** 1257,1262 ****
--- 1257,1264 ----
    AC_CHECK_HEADER([AppKit/AppKit.h], [HAVE_NS=yes],
    		  [AC_MSG_ERROR([`--with-ns' was specified, but the include
    files are missing or cannot be compiled.])])
+   AC_CHECK_HEADER([AppKit/NSFontDescriptor.h], [],
+                   [AC_MSG_ERROR([NSFontDescriptor is required.])])
    NS_HAVE_NSINTEGER=yes
    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include <Foundation/NSObjCRuntime.h>],
                                       [NSInteger i;])],

src/ChangeLog:

2009-06-22  Yavor Doganov  <[email protected]>

	* nsfont.m: Import <AppKit/NSFontDescriptor.h>.

*** nsfont.m	18 юни 2009 12:35:30 +0300	1.26
--- nsfont.m	22 юни 2009 22:35:30 +0300	
***************
*** 37,42 ****
--- 37,47 ----
  #include "character.h"
  #include "font.h"
  
+ /* This header is not included from GNUstep's (0.16.0) AppKit.h.  */
+ #ifdef NS_IMPL_GNUSTEP
+ #import <AppKit/NSFontDescriptor.h>
+ #endif
+ 
  #define NSFONT_TRACE 0
  
  extern Lisp_Object Qns;
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.