bug#4951: 23.1.50; browse-url-default-windows-browser bug + patch
Lennart Borgman <[email protected]> Wed, 18 Nov 2009 02:46:31 +0100
| Newsgroups | gmane.emacs.bugs,gmane.emacs.pretest.bugs |
|---|---|
| Message-ID | <[email protected]> |
browse-url-default-windows-browser does not work any longer. I am unsure when it stopped working, but on at least Windows XP the attached patch seems necessary. Could we please apply this as soon as possible so it will get tested? In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600) of 2009-10-15 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping'
browse-url.patch
(text/x-diff, 1.7 KB)
Index: browse-url.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/net/browse-url.el,v
retrieving revision 1.85
diff -c -r1.85 browse-url.el
*** browse-url.el 6 Nov 2009 05:16:29 -0000 1.85
--- browse-url.el 18 Nov 2009 01:27:21 -0000
***************
*** 444,450 ****
;; applies.
("^/\\([^:@]+@\\)?\\([^:]+\\):/*" . "ftp://\\1\\2/")
,@(if (memq system-type '(windows-nt ms-dos cygwin))
! '(("^\\([a-zA-Z]:\\)[\\/]" . "file:\\1/")
("^[\\/][\\/]+" . "file://")))
("^/+" . "file:///"))
"An alist of (REGEXP . STRING) pairs used by `browse-url-of-file'.
--- 444,450 ----
;; applies.
("^/\\([^:@]+@\\)?\\([^:]+\\):/*" . "ftp://\\1\\2/")
,@(if (memq system-type '(windows-nt ms-dos cygwin))
! '(("^\\([a-zA-Z]:\\)[\\/]" . "file:///\\1/")
("^[\\/][\\/]+" . "file://")))
("^/+" . "file:///"))
"An alist of (REGEXP . STRING) pairs used by `browse-url-of-file'.
***************
*** 834,840 ****
(if dos-windows-version
(shell-command (concat "start " (shell-quote-argument url)))
(error "Browsing URLs is not supported on this system"))
! (w32-shell-execute "open" url)))
(defun browse-url-default-macosx-browser (url &optional new-window)
(interactive (browse-url-interactive-arg "URL: "))
--- 834,840 ----
(if dos-windows-version
(shell-command (concat "start " (shell-quote-argument url)))
(error "Browsing URLs is not supported on this system"))
! (w32-shell-execute nil url)))
(defun browse-url-default-macosx-browser (url &optional new-window)
(interactive (browse-url-interactive-arg "URL: "))