[emacs-w3m:13166] Re: [emacs-w3m/emacs-w3m] Review of Travis-CI configuration is required (#11)
Boruch Baum <[email protected]>
| Newsgroups | gmane.emacs.w3m |
|---|---|
| Message-ID | <emacs-w3m/emacs-w3m/issues/11/[email protected]> |
I see the same thing happening for the other outstanding pull requests, #2 and #4. In those cases also, it was just the changelog file that was stopping travis. I resolved both of those cases as well, but it points out one of the weaknesses in the travis workflow: a merge conflict in a file such as the changelog shouldn't block or stop the process; that kind of file will probably be edited anyway after travis succeeds and a pull request is approved. For example, the submission date and sequences of entries may be altered. Another example is when multiple pull requests are pending - travis will at first approve all, but then when the each is actually merged, travis will fail all the others because of the new changelog entry! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/emacs-w3m/emacs-w3m/issues/11#issuecomment-463681253