[emacs-w3m:13179] Re: [emacs-w3m/emacs-w3m] bb_quibbles (#15)

Masatoshi TSUCHIYA <[email protected]>
Newsgroups gmane.emacs.w3m
Message-ID <emacs-w3m/emacs-w3m/pull/15/review/[email protected]>
tsuchm commented on this pull request.



> @@ -439,7 +440,7 @@ fid=\\([^/]+\\)/type=\\([^/]+\\)/name=\\([^/]*\\)/id=\\(.*\\)$"
 		    (let ((hseq (nth 2 (w3m-action (point))))
 			  (value (w3m-form-get form id)))
 		      (when (> hseq 0)
-			(setq textareas (cons (cons hseq value) textareas)))
+			(push textareas (cons hseq value) textareas))

I think this change contains a mistake.  Do you mean (push (cons hseq value) textareas) ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/emacs-w3m/emacs-w3m/pull/15#pullrequestreview-204666066
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.