[emacs-w3m:13550] [emacs-w3m/emacs-w3m] Suspicious code in defcustom (#70)

jao <[email protected]>
Newsgroups gmane.emacs.w3m
Message-ID <emacs-w3m/emacs-w3m/issues/[email protected]>
I am not sure how this is expected to work, but i was expecting [this line](https://github.com/emacs-w3m/emacs-w3m/blob/master/w3m.el#L706) in the definitionof `w3m-key-binding`: 

```elisp
 `(setq w3m-mode-map (if (eq ,value 'info)
```
to be instead

```elisp
 `(setq w3m-mode-map (if (eq ',value 'info)
```

please note the quote in `',value`, which is missing in the current code, so that an invocation
of the form:

```elisp
(customize-set-variable 'w3m-key-binding 'info)
```

would work as expected (i.e., set w3m-key-binding to the symbol `info`, plus its
other duites).   With the current definition (without the quote in `,value`), evaluating
the `customize-set-variable` call above throws an error (quite naturally) because the
variable `info` is not defined.  The same thing happens if one tries the customize interface.

Is this a genuine bug?

Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/emacs-w3m/emacs-w3m/issues/70
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.