[emacs-w3m:13844] [emacs-w3m/emacs-w3m] user-agents: bugfix, update, improve friendliness (#106)

----==_mimepart_613207e76fc4c_32eec7882256f9
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

1 Variable w3m-user-agent-default-alist

  + It had been defined as a macro, but the macro was specifying a
    symbol when the value of that symbol was needed.

  + To reproduce the bug:

    + Evaluate variable w3m-user-agent

	+ M-x w3m-user-agent-change to something other than the default

    + Evaluate variable w3m-user-agent

	+ M-x w3m-user-agent-change to the default

    + Evaluate variable w3m-user-agent

2 The former values in variable w3m-user-agent-alist have aged, and
  are no longer popular or current.

  + I took the list from a firefox browser extension, but here's a
    resource that may be easier scrape in the future:

  https://raw.githubusercontent.com/Kikobeats/top-user-agents/master/index.json

3 Variable w3m-user-agent-site-specific-alist had previously required
  explicitly entering a user-agent string, but that is most often
  going to be a duplicate of an entry in variable
  w3m-user-agent-alist, so the definition was changed to allow an
  explicit reference to an element of w3m-user-agent-alist, which is
  expected to be more user-friendly / easier to read.
You can view, comment on, or merge this pull request online at:

  https://github.com/emacs-w3m/emacs-w3m/pull/106

-- Commit Summary --

  * w3m-user-agent-default-alist: bugfix macro element
  * user-agent variables: update, and add reference feature

-- File Changes --

    M ChangeLog (12)
    M w3m.el (42)

-- Patch Links --

https://github.com/emacs-w3m/emacs-w3m/pull/106.patch
https://github.com/emacs-w3m/emacs-w3m/pull/106.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/emacs-w3m/emacs-w3m/pull/106

----==_mimepart_613207e76fc4c_32eec7882256f9
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>1 Variable w3m-user-agent-default-alist</p>
<ul>
<li>
<p>It had been defined as a macro, but the macro was specifying a<br>
symbol when the value of that symbol was needed.</p>
</li>
<li>
<p>To reproduce the bug:</p>
<ul>
<li>
<p>Evaluate variable w3m-user-agent</p>
</li>
<li>
<p>M-x w3m-user-agent-change to something other than the default</p>
</li>
<li>
<p>Evaluate variable w3m-user-agent</p>
</li>
<li>
<p>M-x w3m-user-agent-change to the default</p>
</li>
<li>
<p>Evaluate variable w3m-user-agent</p>
</li>
</ul>
</li>
</ul>
<p>2 The former values in variable w3m-user-agent-alist have aged, and<br>
are no longer popular or current.</p>
<ul>
<li>I took the list from a firefox browser extension, but here's a<br>
resource that may be easier scrape in the future:</li>
</ul>
<p><a rel="nofollow" href="https://raw.githubusercontent.com/Kikobeats/top-user-agents/master/index.json">https://raw.githubusercontent.com/Kikobeats/top-user-agents/master/index.json</a></p>
<p>3 Variable w3m-user-agent-site-specific-alist had previously required<br>
explicitly entering a user-agent string, but that is most often<br>
going to be a duplicate of an entry in variable<br>
w3m-user-agent-alist, so the definition was changed to allow an<br>
explicit reference to an element of w3m-user-agent-alist, which is<br>
expected to be more user-friendly / easier to read.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href='https://github.com/emacs-w3m/emacs-w3m/pull/106'>https://github.com/emacs-w3m/emacs-w3m/pull/106</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>w3m-user-agent-default-alist: bugfix macro element</li>
  <li>user-agent variables: update, and add reference feature</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/emacs-w3m/emacs-w3m/pull/106/files#diff-91c5b46dc84a94604a4e4d0caed9bf85590a2eddbb12d2e8dc80badf324a9dfb">ChangeLog</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/emacs-w3m/emacs-w3m/pull/106/files#diff-e0a6b602566bbbc7d41274607bd9e262a57685cbb082f282d4815d32a0fad63a">w3m.el</a>
    (42)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/emacs-w3m/emacs-w3m/pull/106.patch'>https://github.com/emacs-w3m/emacs-w3m/pull/106.patch</a></li>
  <li><a href='https://github.com/emacs-w3m/emacs-w3m/pull/106.diff'>https://github.com/emacs-w3m/emacs-w3m/pull/106.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/emacs-w3m/emacs-w3m/pull/106">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ALIUPN4UYBIFI73FVH55IK3UACW6PANCNFSM5DLR6LNQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&amp;mt=8&amp;pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&amp;referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ALIUPN74T776DUPC4U7EBMTUACW6PA5CNFSM5DLR6LN2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OW6ZSBQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/emacs-w3m/emacs-w3m/pull/106",
"url": "https://github.com/emacs-w3m/emacs-w3m/pull/106",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>

----==_mimepart_613207e76fc4c_32eec7882256f9--