[emacs-w3m:13894] [emacs-w3m/emacs-w3m] Change suspicious links warning customizable (Issue #115)
aaa70 <[email protected]> Tue, 15 Nov 2022 17:36:41 -0800
| Newsgroups | gmane.emacs.w3m |
|---|---|
| Message-ID | <emacs-w3m/emacs-w3m/issues/[email protected]> |
----==_mimepart_63743ea92b4e9_37b2c670406c6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi emacs-w3m contributers,=0D =0D Do you have a plan to make suspicious links warning customizable?=0D Actually, I'm using w3m on emacs mailer, sometimes a lot of =E2=9A=A0=EF=B8= =8F is a bit annoying.=0D =0D Here is my change:=0D =0D ```diff=0D modified w3m.el=0D @@ -2348,6 +2348,16 @@ Echo messages will be displayed no matter what thi= s variable is unless=0D :group 'w3m=0D :type 'boolean)=0D =0D +(defcustom w3m-warning-propertize-function=0D + (lambda (warning)=0D + (if (display-graphic-p)=0D + (propertize "=E2=9A=A0=EF=B8=8F" 'help-echo warning)=0D + (propertize "=E2=96=B2!" 'help-echo warning=0D + 'face '(:background "Yellow" :foreground "Black"))))=0D + "Function used to propertize warn suspicious links"=0D + :group 'w3m=0D + :type 'function)=0D +=0D (defvar w3m-safe-url-regexp nil=0D "Regexp matching urls which are considered to be safe.=0D The nil value means all urls are considered to be safe.=0D @@ -3584,12 +3594,7 @@ external `convert' program respectively."=0D 'help-echo help=0D 'keymap w3m-link-map))=0D (when warning=0D - (insert=0D - (if (display-graphic-p)=0D - (propertize "=E2=9A=A0=EF=B8=8F" 'help-echo warning)=0D - (propertize "=E2=96=B2!" 'help-echo warning=0D - 'face=0D - '(:background "Yellow" :foreground "Black")))))=0D + (insert (funcall w3m-warning-propertize-function warning)))=0D (and (w3m-handle-non-anchor-buttons) (not first)=0D ;; Add a widget so `forward-button' and `widget-forward'=0D ;; work from outside of rendered area."=0D ```=0D =0D Thanks,=0D =0D -- =0D Reply to this email directly or view it on GitHub:=0D https://github.com/emacs-w3m/emacs-w3m/issues/115=0D You are receiving this because you are subscribed to this thread.=0D =0D Message ID: <emacs-w3m/emacs-w3m/issues/[email protected]>= ----==_mimepart_63743ea92b4e9_37b2c670406c6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <p></p>=0D <p dir=3D"auto">Hi emacs-w3m contributers,</p>=0D <p dir=3D"auto">Do you have a plan to make suspicious links warning custo= mizable?<br>=0D Actually, I'm using w3m on emacs mailer, sometimes a lot of <g-emoji clas= s=3D"g-emoji" alias=3D"warning" fallback-src=3D"https://github.githubasse= ts.com/images/icons/emoji/unicode/26a0.png">=E2=9A=A0=EF=B8=8F</g-emoji> = is a bit annoying.</p>=0D <p dir=3D"auto">Here is my change:</p>=0D <div class=3D"highlight highlight-source-diff" dir=3D"auto"><pre>modified= w3m.el=0D <span class=3D"pl-mdr">@@ -2348,6 +2348,16 @@</span> Echo messages will b= e displayed no matter what this variable is unless=0D :group 'w3m=0D :type 'boolean)=0D =0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span>(defcustom w3m-warn= ing-propertize-function</span>=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span> (lambda (warning)= </span>=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span> (if (display-gr= aphic-p)</span>=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span> (propertize= "=E2=9A=A0=EF=B8=8F" 'help-echo warning)</span>=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span> (propertize "= =E2=96=B2!" 'help-echo warning</span>=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span> 'face '(:back= ground "Yellow" :foreground "Black"))))</span>=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span> "Function used to= propertize warn suspicious links"</span>=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span> :group 'w3m</span= >=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span> :type 'function)<= /span>=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span></span>=0D (defvar w3m-safe-url-regexp nil=0D "Regexp matching urls which are considered to be safe.=0D The nil value means all urls are considered to be safe.=0D <span class=3D"pl-mdr">@@ -3584,12 +3594,7 @@</span> external `convert' p= rogram respectively."=0D 'help-echo help=0D 'keymap w3m-link-map))=0D (when warning=0D <span class=3D"pl-md"><span class=3D"pl-md">-</span> (insert</span>= =0D <span class=3D"pl-md"><span class=3D"pl-md">-</span> (if (display-= graphic-p)</span>=0D <span class=3D"pl-md"><span class=3D"pl-md">-</span> (propertize "=E2= =9A=A0=EF=B8=8F" 'help-echo warning)</span>=0D <span class=3D"pl-md"><span class=3D"pl-md">-</span> (propertize "=E2=96= =B2!" 'help-echo warning</span>=0D <span class=3D"pl-md"><span class=3D"pl-md">-</span> 'face</span>=0D= <span class=3D"pl-md"><span class=3D"pl-md">-</span> '(:background= "Yellow" :foreground "Black")))))</span>=0D <span class=3D"pl-mi1"><span class=3D"pl-mi1">+</span> (insert (fun= call w3m-warning-propertize-function warning)))</span>=0D (and (w3m-handle-non-anchor-buttons) (not first)=0D ;; Add a widget so `forward-button' and `widget-forward'=0D ;; work from outside of rendered area."</pre></div>=0D <p dir=3D"auto">Thanks,</p>=0D =0D <p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m= dash;<br />Reply to this email directly, <a href=3D"https://github.com/em= acs-w3m/emacs-w3m/issues/115">view it on GitHub</a>, or <a href=3D"https:= //github.com/notifications/unsubscribe-auth/ALIUPN3EKUDO5QY6HIP2RFDWIQ3CT= ANCNFSM6AAAAAASBTRZKE">unsubscribe</a>.<br />You are receiving this becau= se you are subscribed to this thread.<img src=3D"https://github.com/notif= ications/beacon/ALIUPN3SZO666QNJOCIZB5DWIQ3CTA5CNFSM6AAAAAASBTRZKGWGG33NN= VSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFM53NHI.gif" height=3D"1" width= =3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0; displa= y: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; heig= ht: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><= emacs-w3m/emacs-w3m/issues/115</span><span>@</span><span>github</span><sp= an>.</span><span>com></span></span></p>=0D <script type=3D"application/ld+json">[=0D {=0D "@context": "http://schema.org",=0D "@type": "EmailMessage",=0D "potentialAction": {=0D "@type": "ViewAction",=0D "target": "https://github.com/emacs-w3m/emacs-w3m/issues/115",=0D "url": "https://github.com/emacs-w3m/emacs-w3m/issues/115",=0D "name": "View Issue"=0D },=0D "description": "View this Issue on GitHub",=0D "publisher": {=0D "@type": "Organization",=0D "name": "GitHub",=0D "url": "https://github.com"=0D }=0D }=0D ]</script>= ----==_mimepart_63743ea92b4e9_37b2c670406c6--