[emacs-w3m:13094] Re: A git-ish patch for w3m-db-history

Filipp Gunbin <[email protected]>
Newsgroups gmane.emacs.w3m
Message-ID <[email protected]>
A few comments:

> +; ARGS is not used. It is necessary in order to >/dev/null unnecessary

Usually full-line comments start with two semicolons.

>  (defun w3m-db-history (&optional start size)
[..]
> +  (interactive)
> +  (cond
> +   ((or executing-kbd-macro noninteractive)
> +    (when (not start) (setq start 0))
> +    (when (not size)  (setq size w3m-db-history-display-size)))
> +   (t ; called interactively; possibly indirectly
> +    (setq start (read-number "start: " (or w3m-db-history-display-size 0)))
> +    (setq size (read-number "size: " (or size 0)))))

It's easier to read code when you have normal interactive form: that is,
which either takes string arg-descriptor, or a list which may contain
calls like read-something.  Reading anywhere outside this (interactive
(list ...)) looks awkward.

Filipp
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.