Re: XEmacs nox11 startup issue

Hauke Fath writes:

 > /usr/pkg/lib/xemacs/xemacs-packages/lisp/guided-tour/guided-tour.el:  
 > (assoc "%_Help" (or menubar default-menubar)))
 > which, unlike most of the other files, does not defvar or defconst 
 > 'default-menubar'. I don't see, though, that guided-tour.el would be 
 > invoked during a regular startup.

There are autoloads, and that action (it's more than a mere
definition) is autoloaded.  I'm surprised that -vanilla suppresses the
problem (I would think you need -no-autoloads), but I'll take a look
at that later.  This is bad (guided-tour is ill-behaved because it
initializes itself at XEmacs startup rather than on invocation[1] and
I didn't check that it worked in --without-x11 builds).  At present, I
doubt XEmacs is getting a lot of newbies so you could just omit
guided-tour from your packages.

If you want to include it, try the appended patch.

I'll take a closer look later (and check for other optional but
"normally present" resources it uses), but "later" may very well mean
"Saturday".

Steve

Footnotes: 
[1]  By design -- it's a feature you want newbies to know about if
it's available but they won't be able to find it easily if it's not in
the Help menu.

--- guided-tour.el~	2014-10-25 17:20:02.000000000 +0900
+++ guided-tour.el	2015-11-10 15:13:23.000000000 +0900
@@ -80,7 +80,7 @@
 ;; #### this probably should move to help.el or menubar-items.el
 (defun guided-tour-find-menubar-help-menu (&optional menubar)
   "Return the Help submenu for MENUBAR if present, else nil."
-  (assoc "%_Help" (or menubar default-menubar)))
+  (assoc "%_Help" (or menubar (if-boundp 'default-menubar default-menubar))))
 
 (defun guided-tour-about-xemacs-index (menu)
   "Return the (zero-based) index of the About XEmacs item in MENU.