Re: [PATCH] erc: XEmacs make-obsolete only takes two arguments

>>>>> "Kyle" == Kyle Jones <[email protected]> writes:

    Kyle> Adrian Aichner writes:

    >> +(if (featurep 'xemacs)
    >> +    (make-obsolete 'erc-current-network 'erc-network)
    >> +  (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5"))

    Kyle> This is better written as 

    Kyle> (condition-case nil
    Kyle>     (make-obsolete 'erc-current-network 'erc-network "Obsolete since erc-nets 1.5")
    Kyle>   (wrong-number-of-arguments (make-obsolete 'erc-current-network 'erc-network)))

    Kyle> This way if XEmacs syncs to the three arg version, the code will
    Kyle> automatically start using the extra arg.

Hi Kyle, you're right of course.

I'll follow up with a patch.

It's been good to read you again!

Take care[1],

Adrian

    Kyle> -------------------------------------------------------
    Kyle> This SF.Net email is sponsored by: IBM Linux Tutorials
    Kyle> Free Linux tutorial presented by Daniel Robbins, President and CEO of
    Kyle> GenToo technologies. Learn everything from fundamentals to system
    Kyle> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click


Footnotes: 
[1]  Do real people actually still use this phrase? ;->

-- 
Adrian Aichner
 mailto:[email protected]
 http://www.xemacs.org/



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click