Re: Functions running window-configuration-hook (M-x reimplement-wheel)

"Stephen J. Turnbull" <[email protected]> Tue, 15 Jun 2004 12:17:41 +0900
Newsgroups gmane.emacs.xemacs.design
Organization The XEmacs Project
Message-ID <[email protected]>
Mike, are you following this thread?  Please comment, at least to
confirm that your work in this area is stable and Johann's stuff won't
conflict.

>>>>> "Johann" == Johann Oskarsson <[email protected]> writes:

    Johann> I'm not sure whether I should include the run hooks, or
    Johann> put it in change_window_height, which is not visible on
    Johann> the lisp level, and all of the above functions call.

Isn't there a parallel change_window_width for vertically split
windows?

I would tend to say that all "interesting" window configuration
changes have to change the size of some window, so putting it in those
functions is the right thing to do.

    Johann> I'm also open to sugestions whether
    Johann> window-configuration-hook functions should get the changed
    Johann> frame as an argument?

Shouldn't they get the window?  If you have the window you can get its
frame.

    Johann> There is also the issue of infinite loops, but I don't
    Johann> think I should even try to safeguard that.  Let them who
    Johann> use it take the responsibilty.

No, I really think you should take care of that.  You should find (if
necessary, add) an "in_configuration_change" flag to the frame (or
maybe the window), and disallow recursive calls on that frame
(resp. window).

    Johann> Windows? I look out of windows.

Is that because you can't look _in_?  :-)


-- 
Institute of Policy and Planning Sciences     http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba                    Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
               Ask not how you can "do" free software business;
              ask what your business can "do for" free software.