[PATCH 21.5] fc_config object with NULL pointer
"Stephen J. Turnbull" <[email protected]>
| Newsgroups | gmane.emacs.xemacs.beta,gmane.emacs.xemacs.patches |
|---|---|
| Message-ID | <[email protected]> |
Jerry James writes: > PATCH 21.5 Thank you! > Here is what happened. Nice work, Sherlock! Ship it. > In fc_config_create_using, we wrap the fc_config object as a Lisp > object *twice*. One reference goes onto a weak list and the other > is returned. But these are different objects only in the case of --with-union-type, right? Was the XEmacs where this happens built that way? In a --with-union-type=no, wrap_fc_config just casts the pointer to (Lisp_Object). This *is* a bug, and your patch does fix that bug. I just want to make sure there aren't more of them running around. Unfortunately, we do this all over the place. Eg, in src/EmacsFrame.c:EmacsFrameSetValues we wrap the same frame object about 9 times! Need to sleep, though, so not tonight.... Volunteers? Steve