[AC packages] Fix make bindist
Jerry James <[email protected]>
| Newsgroups | gmane.emacs.xemacs.beta,gmane.emacs.xemacs.patches |
|---|---|
| Message-ID | <CAHCOHQnxscxGCiLnaq-aQuXizLpOWFNZkKSUAQ7UJs3CvaLZ8w@mail.gmail.com> |
APPROVE COMMIT packages On Wed, Jun 18, 2014 at 3:24 AM, Norbert Koch <[email protected]> wrote: > Thanks a lot! I've applied it by hand (too many mailers had their > fingers into this :-)) and now the make works. Ugh, sorry about the mailer damage. One of these days I am really, really going to get gnus working again.... Anyway, thanks for the confirmation. I tried building with 21.5 and this patch, and that also worked. >> And maybe that let should be a let*? > > Sounds reasonable. Actually, no, that won't make any difference. I was just thinking it would emphasize the serial nature of the operation: pop this argument first, then pop that other argument. But as far as the operation of the code goes, it doesn't matter. I am committing the following patch, which means yet another top-level push, Norbert. diff -r 9954f5555c86 ChangeLog --- a/ChangeLog Wed Jun 04 15:49:00 2014 -0600 +++ b/ChangeLog Wed Jun 18 09:09:35 2014 -0600 @@ -1,3 +1,9 @@ +2014-06-18 Jerry James <[email protected]> + + * package-net-packages.el + (package-net-packages-batch-convert-index-to-ini): consume command + line arguments instead of just peeking at them. + 2014-06-02 Jerry James <[email protected]> * Local.rules.template: Support texi2any. Drop support for diff -r 9954f5555c86 package-net-packages.el --- a/package-net-packages.el Wed Jun 04 15:49:00 2014 -0600 +++ b/package-net-packages.el Wed Jun 18 09:09:35 2014 -0600 @@ -145,8 +145,8 @@ "Convert the package index to ini file format." (unless noninteractive (error "`package-net-packages-batch-convert-index-to-ini' is to be used only with -batch")) - (let ((dir (car command-line-args-left)) - (category (cadr command-line-args-left)) + (let ((dir (pop command-line-args-left)) + (category (pop command-line-args-left)) (package-get-require-signed-base-updates nil)) (package-net-packages-convert-index-to-ini dir nil category))) -- Jerry James http://www.jamezone.org/