Re: [Q GNUS] Set defcustom defaults to nil to avoid byte-compile problem

>>>>> Mike Kupfer <[email protected]> writes:

> Yes, that sounds fine.

This is what I pushed. I removed the commented out old code and
inserted the "XEmacs change" tag instead. The package smoketest is OK
so we are good again!

# HG changeset patch
# User Mats Lidell <[email protected]>
# Date 1408570344 -7200
#      Wed Aug 20 23:32:24 2014 +0200
# Node ID 28ae4fab955583570cd551a16e581094d8eaecc3
# Parent  075087fcf3466265e27a32947dd62c192af90358
Use nil as default since calculated value will not byte-compile

2014-08-20  Mats Lidell  <[email protected]>

        * lisp/message.el (message-use-idna): Use nil as default since
        calculated value will not byte-compile.
        * lisp/gnus-art.el (gnus-use-idna): Ditto.

diff -r 075087fcf346 -r 28ae4fab9555 ChangeLog
--- a/ChangeLog	Sun Jun 22 09:03:58 2014 +0200
+++ b/ChangeLog	Wed Aug 20 23:32:24 2014 +0200
@@ -1,3 +1,9 @@
+2014-08-20  Mats Lidell  <[email protected]>
+
+	* lisp/message.el (message-use-idna): Use nil as default since
+	calculated value will not byte-compile.
+	* lisp/gnus-art.el (gnus-use-idna): Ditto.
+	
 2014-06-22  Norbert Koch  <[email protected]>
 
 	* Makefile (VERSION): XEmacs package 1.99 released.
diff -r 075087fcf346 -r 28ae4fab9555 lisp/gnus-art.el
--- a/lisp/gnus-art.el	Sun Jun 22 09:03:58 2014 +0200
+++ b/lisp/gnus-art.el	Wed Aug 20 23:32:24 2014 +0200
@@ -1517,9 +1517,8 @@
 (defvar gnus-article-wash-function nil
   "Function used for converting HTML into text.")
 
-(defcustom gnus-use-idna (and (condition-case nil (require 'idna) (file-error))
-			      (mm-coding-system-p 'utf-8)
-			      (executable-find idna-program))
+;; XEmacs change: Don't calculate a default value
+(defcustom gnus-use-idna nil
   "Whether IDNA decoding of headers is used when viewing messages.
 This requires GNU Libidn, and by default only enabled if it is found."
   :version "22.1"
diff -r 075087fcf346 -r 28ae4fab9555 lisp/message.el
--- a/lisp/message.el	Sun Jun 22 09:03:58 2014 +0200
+++ b/lisp/message.el	Wed Aug 20 23:32:24 2014 +0200
@@ -1475,13 +1475,8 @@
   :type '(radio (const :format "%v  " nil)
 		(string :format "FQDN: %v")))
 
-(defcustom message-use-idna (and (condition-case nil (require 'idna)
-				   (file-error))
-				 (mm-coding-system-p 'utf-8)
-				 (executable-find idna-program)
-				 (string= (idna-to-ascii "räksmörgås")
-					  "xn--rksmrgs-5wao1o")
-				 t)
+;; XEmacs change: Don't calculate a default value
+(defcustom message-use-idna nil
   "Whether to encode non-ASCII in domain names into ASCII according to IDNA.
 GNU Libidn, and in particular the elisp package \"idna.el\" and
 the external program \"idn\", must be installed for this

Yours
-- 
%% Mats