Re: [A21.5] Do not insert timestamps in .elc files

APPROVE 21.5

Jerry James writes:

 > > I'm not sure I agree with this, though.  Why not have the build do
 > >
 > >     xemacs -eval '(setq user-mail-address "[email protected]")'
 > 
 > Good point.  That would be fine.
 [...]

 > Agreed.  How about this patch, then?

"Obviously correct", to borrow Martin's phrase.  Ship it!

Steve

 > 
 > diff -r be31f7878b0d lisp/ChangeLog
 > --- a/lisp/ChangeLog Tue Sep 23 16:50:48 2014 -0600
 > +++ b/lisp/ChangeLog Thu Sep 25 19:54:02 2014 -0600
 > @@ -1,3 +1,8 @@
 > +2014-09-25  Jerry James  <[email protected]>
 > +
 > + * bytecomp.el (byte-compile-insert-header): do not insert
 > + timestamps in .elc comments to get reproducible builds.
 > +
 >  2014-08-05  Aidan Kehoe  <[email protected]>
 > 
 >   * keymap.el:
 > diff -r be31f7878b0d lisp/bytecomp.el
 > --- a/lisp/bytecomp.el Tue Sep 23 16:50:48 2014 -0600
 > +++ b/lisp/bytecomp.el Thu Sep 25 19:54:02 2014 -0600
 > @@ -2159,8 +2159,7 @@
 >      (insert "\n;;; compiled by "
 >      (or (and (boundp 'user-mail-address) user-mail-address)
 >   (concat (user-login-name) "@" (system-name)))
 > -    " on "
 > -    (current-time-string) "\n;;; from file " filename "\n")
 > +    "\n;;; from file " filename "\n")
 >      (insert ";;; emacs version " emacs-version ".\n")
 >      (insert ";;; bytecomp version " byte-compile-version "\n;;; "
 >      (cond
 > 
 > -- 
 > Jerry James
 > http://www.jamezone.org/