Re: Too many toolbar redraws

Aidan Kehoe <[email protected]> Sat, 28 Feb 2015 10:30:56 +0000
Newsgroups gmane.emacs.xemacs.patches
Message-ID <[email protected]>
 Ar an chéad lá de mí Eanair, scríobh Jeff Sparkes: 

 > It appears that the toolbar is being cleared and recreated for every
 > redraw.  I have a patch that only clears the toolbars if the frame is
 > resized, which seems to be the original intent.  I'm not sure if the
 > toolbar even needs to be cleared on the resize, but this patch saves a lot
 > of churn.

You’re right that it shouldn’t be necessary for the toolbar to be created and
redrawn for every redisplay. This patch is a big improvement on the previous
situation, but it is incorrect, in that the various ENABLED-P elements in the
toolbar buttons are ignored. What we should do is pay attention to whether any
of the the toolbar buttons are dirty, and only then redraw.

-- 
‘Tramadol is further fed to cattle […] when working them […] (as draft
animals) so that the animals do not get tired quickly. …’
	— Angewandte Chemie, Sept 2014, describing the social context of
	(synthetic) tramadol having been found in Cameroon tree roots.

_______________________________________________
XEmacs-Patches mailing list
[email protected]
http://lists.xemacs.org/mailman/listinfo/xemacs-patches