Re: Rename `digit-char-p' to `char-digit-p'.
Mike Kupfer <[email protected]> Mon, 22 Jun 2015 16:39:07 -0700
| Newsgroups | gmane.emacs.xemacs.patches |
|---|---|
| Message-ID | <[email protected]> |
Stephen J. Turnbull wrote: > Michael Sperber writes: > > > > The name `digit-char-p' was moved to the core here: > > > > 2015-02-25 Aidan Kehoe <[email protected]> > > > > * cl-extra.el (digit-char-p): Moved to data.c. > > * cl-extra.el (digit-char): Moved to data.c. > > > > > > Unfortunately, this breaks Gnus which defines the same name. So: > > Does it define it differently? Since you say "break" I suppose it > must. They look pretty compatible to me. The one difference that I see is that the core version takes an optional radix argument, and the Gnus version does not. > Either way, why is Gnus defining functions in the global namespace? FWIW, digit-char-p is part of parse-time.el. I don't know offhand why it's packaged with Gnus. In GNU Emacs 24.5, parse-time.el is in the calendar source tree. > I don't really care about the name, but I think it's really obnoxious > to have *both* `digit-char-p' and `char-digit-p' defined. Especially > if the semantics are different. It seems like we could just wrap the Gnus version in (unless (fboundp 'digit-char-p) ...) mike