[PATCH 21.5] Missing DESTDIR in subdir cleanup

Mats Lidell <[email protected]> Tue, 14 Jul 2015 15:40:41 +0200
Newsgroups gmane.emacs.xemacs.patches
Organization The XEmacs Project
Message-ID <[email protected]>
Hi,

This patch has been a while in my workspace so I almost have forgotten
about it. It has to do with a missing DESTDIR. That is something that
won't hit you in everyday builds. Gentoos ebuilds however relies on
DESTDIR functionality so I think I spotted this that way.

On the other hand, from vague memory, I think I then questioned the
need to remove these files at all, (do they even exist!?), so maybe
the whole for loop can be removed. 

Please help me, have a look at it and review this patch.

diff -r cb65bfaf7110 Makefile.in.in
--- a/Makefile.in.in    Fri Mar 27 16:05:15 2015 +0100
+++ b/Makefile.in.in    Tue Jul 14 15:29:17 2015 +0200
@@ -408,7 +408,7 @@
           fi; \
           ${INSTALL_DATA} lib-src/config.values $(DESTDIR)${docdir}/config.values; \
           ${INSTALL_DATA} lib-src/DOC $(DESTDIR)${docdir}/DOC; \
-          for subdir in `find ${archlibdir} -type d ! -name RCS ! -name SCCS ! -name CVS -print` ; \
+          for subdir in `find $(DESTDIR)${archlibdir} -type d ! -name RCS ! -name SCCS ! -name CVS -print` ; \
             do (cd $${subdir} && $(RM) -r RCS CVS SCCS \#* *~) ; done ; \
        else true; fi
 #if (defined(PDUMP) && !defined (DUMP_IN_EXEC)) || (defined (PDUMP) && defined(WIN32_NATIVE))

Yours
-- 
%% Mats