Re: Questions from a small fgdata-next cleanup check
James Hogan via Flightgear-devel <[email protected]>
| Newsgroups | gmane.games.flightgear.devel |
|---|---|
| Message-ID | <[email protected]> |
On 28 May 2026 05:50:21 BST, "An Phúc Nguyễn Vạn" <[email protected]> wrote: >First, Effects/ws30.eff still has a technique that references: > >Shaders/HDR/ws30_old.vert >Shaders/HDR/ws30_old.frag > >So I assume this is not dead code. Is this an intentional fallback path for >older hardware/drivers, or just an older path that has not been cleaned up >yet? I believe this is actually still default. The first technique is conditional on tessellation shaders, and isn't yet as complete as the other version (e.g. water effects missing), and also won't work on platforms with older OpenGL version (mac). There's a setting in render settings called tessellation for it, that would need removing if the current next was made into a release. Stuart said at <https://gitlab.com/flightgear/flightgear/-/work_items/3423#note_3308625000>: >Tesselation is something that Fernando and I experimented with, but never got as advanced as the non-tesselated terrain. I haven't looked at it in ages. IIRC the big problem was handling the roads. >If it is intentionally kept, would a small comment or rename to make the >fallback role clearer be useful? Its not my code, but until tessellation version is either updated to be on par with non tessellation version (in which case "old" wouldn't be incorrect) or its dropped (in which case old would be the only version and renamed then), I'm not sure there's much point doing anything now. Cheers JamesH _______________________________________________ Flightgear-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/flightgear-devel