Re: (PR#12422) stupid AI leaves its city in disorder

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12422 >

On Fri, Mar 04, 2005 at 05:39:35PM -0800, Jason Short wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12422 >
> 
> > [per - Thu Mar 03 23:50:47 2005]:
> > 
> > On Thu, 3 Mar 2005, Jason Short wrote:
> > > Not sure about the bug but your assert is wrong because there is a
> > > generic_city_refresh call built in at the start of CM.Here is a more
> > > comprehensive and correct assert.
> > 
> > No, the assert is correct. The generic_city_refresh call calculates the
> > city state wrong. The city should be in disorder - it is not.
> 
> The assert is surely not correct.  Because the callers pass in cities
> that aren't refreshed the refresh _will_ sometimes change this value.  I
> also find it unlikely that generic_city_refresh is wrong here - this
> function is called so often if it were wrong the whole game would explode.
> 
> However there is certainly a bug in ai_manage_taxes.  I think this patch
> fixes it (the comment explains the bug).  I think it's in S2_0 as well.

cm_query_result should never be clobbering the city; I had noted that
your patch was buggy in #11415 and offered a patch but probably you
didn't see it since apparently the bug was already marked closed.

        -- Benoît