(PR#11219) Terrain flags are not documented

"Jason Short" <[email protected]> Mon, 29 Nov 2004 14:10:23 -0800
Newsgroups gmane.games.freeciv.devel,gmane.games.freeciv.data
Message-ID <[email protected]>
This is a multi-part message in MIME format...

------------=_1101766223-19436-7
Content-Type: text/plain; charset="utf-8"


<URL: http://rt.freeciv.org/Ticket/Display.html?id=11219 >

> [cazfi - Sat Nov 27 14:25:45 2004]:
> 
> 
>   Terrain.ruleset seems to use some flags not mentioned in comments in 
> the beginning nor in any README file.
>   I believe that terrain.c:terrain_flag_from_str():flag_names is 
> authoritative list of flags available for ruleset usage. Compared to it 
> terrain.ruleset lacks comments for "NoCities", "UnsafeCoast" and "Unsafe".

Here's a patch.

-jason


------------=_1101766223-19436-7
Content-Type: text/x-patch; charset="ascii"; name="terrain.diff"
Content-Disposition: inline; filename="terrain.diff"
Content-Transfer-Encoding: 7bit

Index: data/default/terrain.ruleset
===================================================================
RCS file: /home/freeciv/CVS/freeciv/data/default/terrain.ruleset,v
retrieving revision 1.35
diff -u -r1.35 terrain.ruleset
--- data/default/terrain.ruleset	8 Nov 2004 15:15:53 -0000	1.35
+++ data/default/terrain.ruleset	29 Nov 2004 22:09:31 -0000
@@ -160,7 +160,15 @@
 ; flags                = General flags for this terrain:
 ;   - NoBarbs          = Barbarians will not be spawned here.
 ;   - NoPollution      = Pollution will not be put on this terrain type.
+;   - NoCities         = Cities may not be built or found on this terrain.
 ;   - Starter          = Players will only be started on "Starter" terrain.
+;   - CanHaveRiver     = Set to 1 if this terrain can have river on it (the
+;                        actual chance of river generation is controlled
+;                        separately).
+;   - UnsafeCoast      = This terrain does not provide a safe coast for
+;                        F_TRIRIEME units.
+;   - Unsafe           = This terrain is unsafe for alll units that travel
+;                        on it.
 ;   - Oceanic          = This is an "ocean" terrain.  This has a big effect
 ;                        on gameplay.  Naval units can move on oceanic terrain,
 ;                        while land units cannot.  Oceanic tiles can be used
@@ -169,9 +177,6 @@
 ;                        units.  Most terrain improvements can only be built
 ;                        on land.  Oceanic terrain has no zones of control.
 ;                        The list goes on.
-;   - CanHaveRiver     = Set to 1 if this terrain can have river on it (the
-;                        actual chance of river generation is controlled
-;                        separately).
 ; helptext	       = optional help text string; should escape all raw 
 ;		         newlines so that xgettext parsing works
 

------------=_1101766223-19436-7--