[freeciv/freeciv] 2354e9: gtk4x: Fix icon sizes with new gtk releases

freeciv-commits <[email protected]>
Newsgroups gmane.games.freeciv.devel
Message-ID <freeciv/freeciv/push/refs/heads/main/[email protected]>
  Branch: refs/heads/main
  Home:   https://github.com/freeciv/freeciv
  Commit: 2354e913f0cb4aa875cabc7845358db825f270e9
      https://github.com/freeciv/freeciv/commit/2354e913f0cb4aa875cabc7845358db825f270e9
  Author: Christian Mauderer <[email protected]>
  Date:   2026-01-20 (Tue, 20 Jan 2026)

  Changed paths:
    M client/gui-gtk-5.0/citizensinfo.c
    M client/gui-gtk-5.0/dialogs.c
    M client/gui-gtk-5.0/editgui.c
    M client/gui-gtk-5.0/editprop.c
    M client/gui-gtk-5.0/gotodlg.c
    M client/gui-gtk-5.0/messagewin.c
    M client/gui-gtk-5.0/pages.c
    M client/gui-gtk-5.0/plrdlg.c
    M client/gui-gtk-5.0/repodlgs.c
    M client/gui-gtk-5.0/unitselect.c
    M client/gui-gtk-5.0/wldlg.c

  Log Message:
  -----------
  gtk4x: Fix icon sizes with new gtk releases

GTK has set the maximum size of objects that use the iconhelper to the
size of icons in the context of the widget (see [1]). Unfortunately, the
gtk_cell_renderer_pixbuf_snapshot which is used to render pixbufs
internally uses that iconhelper.

This commit adds a hack that increases the maximum icon size for all
potentially affected dialogs to work around that problem.

Exclude pages.c: In that dialog there are tick boxes that would adapt to
the icon size too.

See RM #1874

[1] https://gitlab.gnome.org/GNOME/gtk/-/commit/38b0a153e2e25034eec7722d15c89211dad679d5

Signed-off-by: Christian Mauderer <[email protected]>



To unsubscribe from these emails, change your notification settings at https://github.com/freeciv/freeciv/settings/notifications
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.