Re: New Tax Rate Dialog

Hi Ben,

Fantastic. Many, many thanks for spending time contributing code :)

We're pretty relaxed about CVS access; I'll set up access for you sometime
tomorrow (unfortunately my cablemodem is out of commission at the moment,
and the only dialup access I have is behind a firewall)

If you're comfortable generating a diff, then you can send that to the list
(zip it if it's large) and I'll commit it on your behalf. Otherwise, just
check in the changes using CVS after I send you your account details (be
sure to do a cvs update first). For fame and glory, you should also go ahead
and modify the CREDITS.txt to add yourself as a contributor :)

About the tax rate slider order... that's one of the reasons I really wanted
to get involved in the java client. IMHO, the UI of the C client sucks a
little (a lot in some places), and I know for a fact it's easy to get a
pretty nice UI going in Java. So if you feel it improves the aesthetics or
the usability to move things around, or even implement them completely
differently then go for it :)

The server options would be really useful too: you'll definitely have to get
your feet wet here: I think the packet handler probably isn't written yet
for dealing with this yet.. fun stuff :)

Thanks,

Brian


----- Original Message -----
From: "Ben Mazur" <[email protected]>
To: "Brian Duff" <[email protected]>; <[email protected]>
Cc: <[email protected]>
Sent: Friday, December 07, 2001 4:30 AM
Subject: New Tax Rate Dialog


> Well I took a look at the TODO.txt and picked what seemed to
> be one of the easier tasks there: the tax rate dialog.
> After a little bit of programming (more than I originally
> thought, though) it's done.  Now what do I do with it?
>
> Now I have a few new classes and a few changes to existing
> classes.  Do I upload them to CVS somewhere?  Attach the new
> and altered classes to a list email?  Generate a diff file
> somehow?
>
> Also, on the tax rate topic, the C client puts the three
> rates in the order Tax, Lux, Sci.  I prefer Tax, Sci, Lux.
> Is there any reason I shouldn't change it?
>
> I was thinking of working on the server options display
> dialogs next to get my feet wet in the network code.
>
> Thanks,
> Ben
>
> ----- Original Message -----
> From: "Brian Duff" <[email protected]>
> To: "Ben Mazur" <[email protected]>; <[email protected]>
> Cc: <[email protected]>
> Sent: Thursday, December 06, 2001 6:42 AM
> Subject: [FreeCiv-Java] Re: Hello there
>
>
> > Welcome Ben, any help would be greatly appreciated :)
> >
> > There's a list of stuff to do in the TODO.txt file
> included in the source
> > distribution, so feel free to pick up anything included in
> there, or
> > anything else you feel like getting involved in (as you
> probably noticed,
> > there's a lot of stuff still to be done :) ).
> >
> > Let us know if you have any questions...
> >
> > Thx,
> >
> > Brian
> >
> > ----- Original Message -----
> > From: "Ben Mazur" <[email protected]>
> > To: <freeciv-java-0/[email protected]>
> > Sent: Wednesday, December 05, 2001 10:38 PM
> > Subject: [FreeCiv-Java] Hello there
> >
> >
> > > Hi,
> > >
> > > My name is Ben Mazur and I'm a programmer from Ohio and
> I am
> > > interesting in helping out.  I've downloaded the latest
> > > release and have been browsing through the source a
> little.
> > > I was wondering if you had any tasks to suggest that I
> could
> > > use to familiarize myself with the source a little more.
> > >
> > > Thanks,
> > > Ben Mazur
> > >
> > >
> > >
> >
> >
> >
>
>