configure bug about libX11 availability

Hi, all.

A Torcs user (Mario Veygel) has the exact same compilation pb
I experienced some time ago on Mandriva 2008 x86_64, for 1.3.0 and also CVS :

 > [Torcs-users] torcs compilation problem
 > checking for XOpenDisplay in -lX11... no
 > configure: error: Can't find libX11. Please check config.log and if you
 > can't solve the problem send the file to
 > torcs-users@li... with the subject "torcs compilationproblem"
 >
 > Of course I have libX11 and also the devel packages installed
 > (Ubuntu Hardy), so I checked what's wrong here, and found the following
 > bug in ./configure, line 6454:
 >
 > LDFLAGS="$LDFLAGS -L$x_libraries"
 > ^^
 >
 > That -L there is wrong. If I remove it, configure succeeds.
 > The same bug exists in the CVS sources.

There is probably a small issue with libX11 detection
that should be fixed (don't know how).
But waiting for that fix, I would suggest modifying configure.in
the following way : replace the line :

LDFLAGS="$LDFLAGS -L$x_libraries"

by the 3 following lines :

if test "$x_libraries" != ""; then
   LDFLAGS="$LDFLAGS -L$x_libraries"
fi

Any suggestion ?

Cheers,

Jean-Philippe.

PS: In configure.in, there is also 2 lines that could be removed,
that is the second occurence of the 2 following lines :

CFLAGS="$CFLAGS $ADDCFLAGS"
CXXFLAGS="$CXXFLAGS $ADDCFLAGS"

It's not a big issue, but it duplicates some flags in compilation commands.

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone