: Diameter API I-D, v4

David Lehmann <[email protected]> Thu, 13 Oct 2005 16:05:02 -0400
Newsgroups gmane.ietf.aaa
Message-ID <[email protected]>
Hello,

I found a couple minor problems with the current API I-D version.

Compile issues
==========

In section 3.1.1,
typedef sockaddr_storage IP_ADDR;
should be
typedef struct sockaddr_storage IP_ADDR;

BTW, to be consistent, should it be defined as "AAA_IP_ADDR"?

In section 3.4.2,
typedef AAAReturnCode (*func)(AAAMessage *message) AAACallback;
should be
typedef AAAReturnCode (*AAACallback)(AAAMessage *message);


Editorial issues
==========
3.2.4 "port" is described in the description but is not in the structure.
3.4.2.5 "c ommand-specific" should be "command-specific"
3.4.3.1 Two periods at the end of the abortCallback description.


-- 

David Lehmann
Ulticom, Inc.
http://www.ulticom.com