Re: : Diameter API I-D, v4

Comments inline.

On Tue, 2005-10-13 at 16:08, David Lehmann wrote:
>
>Hello,
>
>I found a couple minor problems with the current API I-D version.
>
>Compile issues
>==========
>
>In section 3.1.1,
>typedef sockaddr_storage IP_ADDR;
>should be
>typedef struct sockaddr_storage IP_ADDR;
>
>BTW, to be consistent, should it be defined as "AAA_IP_ADDR"?

I agree with both comments.

>
>In section 3.4.2,
>typedef AAAReturnCode (*func)(AAAMessage *message) AAACallback;
>should be
>typedef AAAReturnCode (*AAACallback)(AAAMessage *message);
>
>

Fixed.

>Editorial issues
>==========
>3.2.4 "port" is described in the description but is not in the
>structure.

Description of port removed.

>3.4.2.5 "c ommand-specific" should be "command-specific"

Fixed.

>3.4.3.1 Two periods at the end of the abortCallback description.

Fixed.


Thanks for all the comments!  I'll spin an updated version after the
next meeting.


-Dave